Build using emcc failed about rv32emu

[jserv]

I aimed to simplify the process by treating emcc as a cross-compiler, thereby tweaking the build rules. If you have any proposed changes, please don't hesitate to submit them.

[ChinYikMing]

May I know the concern of the way to check which compiler was used in mk/toolchain.mk of commit ? @jserv

[jserv]

The commit f484a4b was used as the workaround for Apple LLVM toolchain, and the above resulted from incorrect detection of toolchain built upon clang or gcc.

[ChinYikMing]

The commit f484a4b was used as the workaround for Apple LLVM toolchain, and the above resulted from incorrect detection of toolchain built upon clang or gcc.

The version of Apple LLVM toolchain of my machine is Homebrew clang version 17.0.6
(run clang --version | head -n 1) and I am able to detect clang and build rv32emu with it. May I know the Apple LLVM toolchain of your machine?

[jserv]

The version of Apple LLVM toolchain of my machine is Homebrew clang version 17.0.6 (run clang --version | head -n 1) and I am able to detect clang and build rv32emu with it. May I know the Apple LLVM toolchain of your machine?

The workaround was applied to Xcode 15.
See commit 618d4f1

[ChinYikMing]

I think we are referring to different things. Let me rephrase the question:

May I know the concern of changing from this

ifneq ($(shell $(CC) --version | head -n 1 | grep emcc),)
     CC_IS_EMCC := 1
else ifneq ($(shell $(CC) --version | head -n 1 | grep clang),)
     CC_IS_CLANG := 1
else
     ifneq ($(shell $(CC) --version | grep "Free Software Foundation"),)
         CC_IS_GCC := 1
     endif
endif

to this in this commit f484a4b?

ifneq ($(shell $(CC) --version | head -n 1 | grep emcc),)
     CC_IS_EMCC := 1
endif
ifneq ($(shell $(CC) --version | head -n 1 | grep clang),)
     CC_IS_CLANG := 1
endif
ifneq ($(shell $(CC) --version | grep "Free Software Foundation"),)
     CC_IS_GCC := 1
endif

Note that the former will successfully build with emcc.