Plugin incompatible with Dokuwiki Hogfather= about dokucrypt2

[impactfactory]

Perhaps same here: adding the secret tags is not doing anything... no encryption happening, no dialogue popping up.

[syntaxseed]

I will look into this. Thanks for the bug report.

[syntaxseed]

Temporary fix in place. Please update or un-install / re-install. This fix is under review/testing.

[impactfactory]

Thanx a lot for the superfast reply. re-installing has no effect yet.

[syntaxseed]

@impactfactory the new version 2020-10-14 fixes the problem on my instance of Dokuwiki HogFather. Please confirm you have that version, then shift+refresh & try again.

If it doesn't work, I need more info - like any errors appearing in your browser's js console.

[impactfactory]

It doesnt work, perhaps Im doing something wrong with the syntax? is it right to do this syntax: <SECRET> xxxxx</SECRET> f.e. to protect the passwort inbetween? No popup for encryption is showing up. On ftp / direct txt-file everything still visible. Release 2020-07-29 "Hogfather" and docscript 2020-10-14.

[syntaxseed]

That syntax is correct. I wonder about something... give me a minute.

[impactfactory]

a new error happens, thats all yes i have quite some plugins running. do you need a list? that would narrow it down as you for sure have some plugins too.

…

Am 16.10.2020 um 15:56 schrieb SyntaxSeed ***@***.***>: @impactfactory <https://github.com/impactfactory> .... do you have access to edit the file in your DokuWiki installation? If so, I'm curious to try something. If you can open the file lib/plugins/dokucrypt2/action.php and comment out (two forward slashes) the defer line for the init javascript. Like so: $event->data["script"][] = array ( "type" => "text/javascript", "src" => DOKU_BASE."lib/plugins/dokucrypt2/init.js", //"defer" => "defer", "_data" => "", ); Save the file, then shift-refresh your dokuwiki page. See if that solves it. Otherwise this is tough as I can't reproduce on my end. Maybe it's conflicting with other plugins. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33BYCLGAUMGJEYOGNWDSLBGHJANCNFSM4SL6O4BQ>.

[syntaxseed]

@impactfactory .... I have attempted a fix for you. It's in another branch. If you can download the zip for this plugin and replace the files you are using in /lib/plugins/dokucrypt2/ with this:

https://github.com/syntaxseed/dokucrypt2/archive/hogfather-fix-1.zip

Shift+refresh your dokuwiki webpage then try again to create a secret block.

PS - thank you for your time helping to debug this. :)

[syntaxseed]

@impactfactory yes the comment out the defer line didn't work, I had deleted that comment. Try the new version of the plugin in the zip file above. Thank you so much for your help.

[impactfactory]

im glad to help - while sitting in a train with a mask :) now the whole installation is crashing, my browser just says he cannot open this website...

…

Am 16.10.2020 um 16:08 schrieb SyntaxSeed ***@***.***>: @impactfactory <https://github.com/impactfactory> yes the comment out the defer line didn't work, I had deleted that comment. Try the new version of the plugin in the zip file above. Thank you so much for your help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33GMKBJTIQAPWSXVF63SLBHUTANCNFSM4SL6O4BQ>.

[impactfactory]

ok, i found out why it crashed. you should not have folders like xxxdocucrypt2-old in the plugins folder. still testing

…

Am 16.10.2020 um 16:08 schrieb SyntaxSeed ***@***.***>: @impactfactory <https://github.com/impactfactory> yes the comment out the defer line didn't work, I had deleted that comment. Try the new version of the plugin in the zip file above. Thank you so much for your help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33GMKBJTIQAPWSXVF63SLBHUTANCNFSM4SL6O4BQ>.

[impactfactory]

SORRY, NO DIFFERENCE

…

Am 16.10.2020 um 16:08 schrieb SyntaxSeed ***@***.***>: @impactfactory <https://github.com/impactfactory> yes the comment out the defer line didn't work, I had deleted that comment. Try the new version of the plugin in the zip file above. Thank you so much for your help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33GMKBJTIQAPWSXVF63SLBHUTANCNFSM4SL6O4BQ>.

[impactfactory]

PERHAPS A HINT: IT DOESNT PARSE THE TAGS IN THE NON-EDIT VIEW

…

Am 16.10.2020 um 16:04 schrieb SyntaxSeed ***@***.***>: @impactfactory <https://github.com/impactfactory> .... I have attempted a fix for you. It's in another branch. If you can download the zip for this plugin and replace the files you are using in /lib/plugins/dokucrypt2/ with this: https://github.com/syntaxseed/dokucrypt2/archive/hogfather-fix-1.zip <https://github.com/syntaxseed/dokucrypt2/archive/hogfather-fix-1.zip> Shift+refresh your dokuwiki webpage then try again to create a secret block. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33FS2W7JRSQRWOZMVOLSLBHHVANCNFSM4SL6O4BQ>.

[syntaxseed]

PERHAPS A HINT: IT DOESNT PARSE THE TAGS IN THE NON-EDIT VIEW

Correct, Dokuwiki syntax within an encrypted block are not parsed. This is already a reported enhancement request.

[syntaxseed]

Well... this is beyond my time and ability to fix. Both versions of the plugin work for me. I'll have to leave the bug open and see if anyone else wants to chime in or attempt a fix. I am in the process of getting advice on the DokuWiki forum. Sorry @impactfactory.

[impactfactory]

OK. I CAN ADD LIST OF PLUGINS. NOT GOOD THAT PLUGINS CAN INTERFERE EACH OTHER. COULD YOU ADD THE LINK TO THE FORUM HERE? THANK YOU.

…

Am 16.10.2020 um 16:24 schrieb SyntaxSeed ***@***.***>: Well... this is beyond my time and ability to fix. Both versions of the plugin work for me. I'll have to leave the bug open and see if anyone else wants to chime in or attempt a fix. I am in the process of getting advice on the DokuWiki forum. Sorry @impactfactory <https://github.com/impactfactory>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33FZS7NFODOHLD3YCOLSLBJQTANCNFSM4SL6O4BQ>.

[syntaxseed]

It would be better if you can disable all your plugins besides this one and see if the problem still occurs. As a free plugin that very few people use, I unfortunately don't have time to install and test against a bunch of plugins. :)

[syntaxseed]

I've been looking for advice related to this plugin here:

https://forum.dokuwiki.org/d/18356-plugin-dev-run-js-on-page-load

[impactfactory]

I deactivated all plugins and found out that the Plugin "Fastwiki" is causing docucrypt2 not to work. "Fastwiki" seems to have many bugs.

Also as I see it now: I wonder if it is intentional that this descryption message blocks appear?

I don't understand what benefit it provides.

I disabled the toggle button in the javascript and did also the translations there. Now its really useful - thanx!!

[syntaxseed]

@impactfactory thanks for the research! I have added fastwiki to the list of conflicting plugins.

I will look into the spacing issue.

Yes you can toggle the visibility of the encrypted block. This was a feature of the original plugin which I took over.

[impactfactory]

nice. for endusers i woudl use this terms (german added) display / anzeigen hide / verstecken and the toggle I would deactivate. seems to have no benefit in my case….. I changed all secret tags to collapse=1. I would do that as default as it makes a page very confusing if you see this text about the javascript 20 times on it.

…

Am 19.10.2020 um 15:52 schrieb SyntaxSeed ***@***.***>: @impactfactory <https://github.com/impactfactory> thanks for the research! I have added fastwiki to the list of conflicting plugins. I will look into the spacing issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARLL33AM6RWVZJI3SR2SESTSLRADLANCNFSM4SL6O4BQ>.

[syntaxseed]

@impactfactory

I agree with several of your suggestions. PR #9 addresses these with a new version of DokuCrypt2: version 2020-10-19.

• Added spacing between the decrypt and toggle visible links.
• Added CSS classes to links and PRE blocks to allow user styling.
• Encrypted blocks are now collapsed by default.

[syntaxseed]

Additional suggestions please create a new issue.