Implement getpeercert about python-mbedtls

[Synss]

Hi! That seems reasonable, I will see what I can do.

[Synss]

The standard SSLSocket.getpeercert() returns a dict for binary_form=False but I have wrapped the x509 part of mbedTLS so I would rather return an mbedtls.x509.CRT instance. They can be converted to DER with bytes() and PEM with str().

[skelsec]

I have got it working by

def getpeercert(self, binary_form=False):
        crt = _tls.mbedtls_ssl_get_peer_cert(&self._ctx)
        if binary_form is False:
            raise Exception('Not supported!')
        return crt.raw.p[0:crt.raw.len]

This is what is expected by PEP when binary_form=True. I'm just not sure what to do with the pointer. Should it be freed?

[skelsec]

sorry I haven't noticed you already pushed, it's okay for me

[Synss]

sorry I haven't noticed you already pushed, it's okay for me

sure, no problem.

I'm just not sure what to do with the pointer. Should it be freed?

I don't think so. I think it is a view on the peer certificate. At least, that is how I interpret the documentation and the fact that it is returned as a const *. So copying and returning looks good to me.