Coder Social home page Coder Social logo

Comments (6)

satrun77 avatar satrun77 commented on August 16, 2024 2

My bad steps are not correct :)

I will test it and give correct steps, but the code still wrong

from silverstripe-advancedworkflow.

GuySartorelli avatar GuySartorelli commented on August 16, 2024 1

For future reference:

Install workflow module and start using it.

This is not enough steps to reproduce this bug. "start using it" doesn't help someone like me who never uses this module and therefore doesn't know at what step this is likely to trigger. :p

But you've given proper steps in the PR so I'll just copy those in here for you.

from silverstripe-advancedworkflow.

satrun77 avatar satrun77 commented on August 16, 2024 1

Update the steps. :)

from silverstripe-advancedworkflow.

GuySartorelli avatar GuySartorelli commented on August 16, 2024

That said, I'm unable to reproduce this bug using those reproduction steps on a fresh installation of silverstripe/installer with this module added.

Can you please:

  1. Confirm you did in fact reproduce this in a fresh installation
  2. Clarify what needs to be in the "basic workflow"
  3. Add any additional steps that might be missing (even if it seems trivial) - I only follow the exact steps as provided, so there may be something you're doing that seems obvious to you but which I haven't done

from silverstripe-advancedworkflow.

satrun77 avatar satrun77 commented on August 16, 2024

I have updated the steps.

yes, I have tested it in a fresh installer. I have one just for that :)

Reading the code the argument is incorrect. They are matching the old style.

from silverstripe-advancedworkflow.

GuySartorelli avatar GuySartorelli commented on August 16, 2024

Thanks for reporting and fixing that. It'll be automatically tagged by GitHub actions.

from silverstripe-advancedworkflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.