Comments (6)
My bad steps are not correct :)
I will test it and give correct steps, but the code still wrong
from silverstripe-advancedworkflow.
For future reference:
Install workflow module and start using it.
This is not enough steps to reproduce this bug. "start using it" doesn't help someone like me who never uses this module and therefore doesn't know at what step this is likely to trigger. :p
But you've given proper steps in the PR so I'll just copy those in here for you.
from silverstripe-advancedworkflow.
Update the steps. :)
from silverstripe-advancedworkflow.
That said, I'm unable to reproduce this bug using those reproduction steps on a fresh installation of silverstripe/installer
with this module added.
Can you please:
- Confirm you did in fact reproduce this in a fresh installation
- Clarify what needs to be in the "basic workflow"
- Add any additional steps that might be missing (even if it seems trivial) - I only follow the exact steps as provided, so there may be something you're doing that seems obvious to you but which I haven't done
from silverstripe-advancedworkflow.
I have updated the steps.
yes, I have tested it in a fresh installer. I have one just for that :)
Reading the code the argument is incorrect. They are matching the old style.
from silverstripe-advancedworkflow.
Thanks for reporting and fixing that. It'll be automatically tagged by GitHub actions.
from silverstripe-advancedworkflow.
Related Issues (20)
- advancedworkflow.js breaks if Workflow actions are not on page in CMS HOT 1
- ...references nonexistent WorkflowApplicable in 'extensions' HOT 2
- ImportForm not rendered HOT 4
- Layout in the "Restrict to Users" section in Workflow definition is broken HOT 2
- Creating a new workflow definition without title throws 500 HOT 2
- Pending approval read-only view broken for content block page
- CMS preview actions nav broken
- Publishing schedule workflow breaks for the draft page if I click on the "Save" button first and then click on the "Apply for approval" button
- Restrict to Users / Groups in Workflow Definition not working HOT 1
- Broken Build - 5.4.x-dev - PHPCS
- Scheduled Publishing Job (WorkflowPublishTargetJob) results in broken job HOT 1
- Save changes on Workflow-Step results in layout-broken landing-page
- Modal formatting is slightly broken with silverstripe/admin 4.12
- silverstripe/versioned 1.13.0 removes deprecated functionality, preventing workflow diff functionality HOT 4
- No end-to-end coverage - need to create behat tests
- Default branch is out of date on several repositories
- Wrong namespace for imports HOT 1
- Too many unwanted icons visible in workflow manage interface HOT 1
- Set up a Workflow without Notification Email HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-advancedworkflow.