Coder Social home page Coder Social logo

Comments (2)

lbovet avatar lbovet commented on August 25, 2024

This is quite a change in the semantics introducing incompatibility. This will break some of our use cases because we forward queued requests to other queues. We will have to remove this new header.
I would prefer to let this be done in client code (this is a logging specific feature), clients code can just make a copy of the x-queue header into a custom header for logging purpose.
Headers are part of the gateleen API. If their semantic changes, the API changes.

from gateleen.

mcweba avatar mcweba commented on August 25, 2024

As discussed with @lbovet, we don't add this functionality to gateleen itself. To log this header anyway, an additional header has to be added to the request which then will be logged. See example code below:

private void addQueueLogHeader(HttpServerRequest request){
    String queue = request.getHeader("x-queue");
    if(queue != null){
        request.headers().set("x-queue-log", queue);
    }
}

This issue will be closed without modification.

from gateleen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.