item.callback not triggered when item.disabled callback returns false. about jquery-contextmenu

[dcoder2099]

(note, when I originally logged this issue, I mis-stated that the behavior occurs when item.disabled returns true. That was an error in describing the problem on my part. The issue does exist as is evident by the steps to reproduce I outline.

[dcoder2099]

Looks like the issue is with line 528 of jquery.contextMenu.js... in the case when opt.items[key].disabled is not a simple property but rather a callback function, that second parameter to the if condition returns true (because it is true that .disabled is there -- it is a function declaration. If I get a chance, I'll work this up in a fork and submit a pull request.

[dcoder2099]

In case I never get around to that:

diff --git a/jquery.contextMenu.js b/jquery.contextMenu.js
index 759bf68..48d0821 100755
--- a/jquery.contextMenu.js
+++ b/jquery.contextMenu.js
@@ -520,12 +520,13 @@ var // currently active contextMenu trigger
                itemClick: function(e) {
                        var $this = $(this),
                                data = $this.data(),
+                               disabled = $this.hasClass('disabled'),
                                opt = data.contextMenu,
                                root = data.contextMenuRoot,
                                key = data.contextMenuKey;

                        // abort if the key is unknown or disabled
-                       if (!opt.items[key] || opt.items[key].disabled) {
+                       if (!opt.items[key] || disabled) {
                                return;
                        }

[rodneyrehm]

Thanks, missed this at the initial rewrite. Fixed!