Improvement ideas about async-http-client

[Lukasa]

The fallback to concurrent connections idea should be part of a wider pooling discussion. The correct abstraction for a connection pool from the perspective of the rest of the code is "ask for a connection, get back a future that fulfils with one". How that future is fulfilled is an implementation strategy of the pool. In general, the pool should do N-ary connnections except for protocols that explicitly require multiplexing (e.g. HTTP/2).

Re DNS caching, I'm highly suspicious of solving this separately from the resolver. The resolver should own caching.

Rather than support outputting traffic to PCAP files, it would likely be better to provide an escape hatch for pipeline configuration that would allow users to add PCAP handlers themselves, as you've suggested separately.

[artemredkin]

Thank you for feedback!

Regarding custom redirects, what do you think about API similar to URLSession:

protocol HTTPDelegate {
    func willRedirect(to url: URL) -> Bool
}

[PopFlamingo]

@Lukasa Thanks again for your feedback. As discussed I'll soon open an issue to get pool design ideas so that anyone who wants can use it as a starting point for an implementation. I'll give it a go and see where this leads me.

@artemredkin Thank you! The points I'm thinking about are:

• Should we consider some redirection policies as needed commonly enough to be implemented by the client itself?
• Regarding the potential need to download the content of a redirect response: there probably are cases where this would be wanted, if there is a redirection delegate maybe it could also get to choose wether or not it wants to read response contents?
• Should we use a delegate or a closure?

[weissi]

Just in case someone wanted to work on the pcap stuff, I happened to have a WIP patch lying around anyway: pcaps.txt

If you save the pcaps.txt as pcaps.patch (sorry, github doesn't allow .patch extensions!?!) you should be able to git apply pcaps.patch.

[PopFlamingo]

@weissi Thank you!

Will close this issue for now since I opened a new issue regarding pooling design advice (#25 ).