Comments (16)
hrmmm, i guess that's what you get for doing monster monkey patches :)
wanna give it a try?
from routing-filter.
Honestly I looked first and then filed the issue. :-)
from routing-filter.
I've done some initial work to make routing-filter compatible with the new journey router in rails 3.2 - you can see/add/help with the process in my fork using the rails-3.2 branch. With a vey small test application using the pagination and locale filters everything seems to work ok, but I'm battling testing errors on every corner so i'm not too sure about the whole suite.
I've got test failures on 2.3.14 (must be unrelated to my patches), 3.0 is ok, 3.1 and 3.2 don't want to run the testsuite currently.
Gonna submit this as pull request as soon as i'm confident i've whipped everything into shape.
from routing-filter.
I think I've whipped everything into shape, tests are all green on ruby 1.8.7, ruby 1.9.2 and ruby 1.9.3 for rails 2.3, 3.0, 3.1 and 3.2
I've sent pull requests #32, #33 and #34 for the different stuff (rails 2.3 bug, test suite and rails 3.2 compatibility)
from routing-filter.
@yabawock wow, thank you for all this work.
i'm currently super busy with travis ci and other things. so if you were interested i'd just add you as a collaborator and you could apply these fixes yourself? wdyt?
from routing-filter.
@svenfuchs I'd be honored
from routing-filter.
@yabawock my pleasure :)
welcome on board!
from routing-filter.
@parndt
I've merge all fixes into the master branch, so everything should be ok for your Rails 3.2 application. Please go ahead, bundle from master and give it a try.
from routing-filter.
I will make a gem with beta
suffix as soon as possible.
from routing-filter.
I've pushed routing-filter-0.3.0.beta
. Please check if it works well.
Also I wrote CHANGELOG
. Modify it if necessary.
from routing-filter.
I've updated an app of mine to Rails 3.2.0.rc1 today and all tests are green and a quick check in the browser didn't reveal any oddities either.
from routing-filter.
@yabawock w00t :)
from routing-filter.
Thanks.
I will remove beta
from the version number around 10th January and publish it as a gem if no serious issues are reported.
from routing-filter.
@kuroda thank you so much!
from routing-filter.
Don't mention it! I enjoy making and publishing gems.
from routing-filter.
I have published a new gem routing-filter-0.3.0
. Check it out!
from routing-filter.
Related Issues (20)
- Inherited_resources & Simple_form gems - undefined method _path when building form HOT 1
- 0.4.0.pre Does Not Do Proper Routing HOT 5
- Didn't work on rails 4 HOT 2
- Is this gem support alive? HOT 2
- Devise "Not found. Authentication passthru."
- rails4 undefined local variable or method map HOT 5
- Set :include_default_locale to true ignored HOT 5
- Support for case insensitive locales HOT 9
- Is there a plan to support Rails 5 ?
- New release ? HOT 8
- How to use filter in a block?
- I'm not able to make a custom filter work
- Routing Error instead of fallback to en
- Avoiding duplicate content SEO penalty HOT 2
- Why default locale is not fallen back to? HOT 1
- Update routing-filter to allow rails 5.2
- Won't work with Rails 6.1 HOT 5
- Please release new gem version HOT 4
- Filter locale breaks default_url_options in tests (setting the Locale from URL Params)
- README and repo description (on github) reference artweb-design HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from routing-filter.