Comments (21)
Hi there!
Yeah, this sounds like a great idea. I have set up a an article:
https://github.com/christianalfoni/react-webpack-cookbook/wiki/Loading-SVG
It would be great if you had time to put in what you have now. Something is better than nothing :-) Then we can keep work on it if necessary? That would be awesome :-)
from webpack-book.
@christianalfoni thanks man! Sounds like a good plan, start with something then improve. Sure I can do that. I'll put something together tonight (:
from webpack-book.
@christianalfoni silly question: how do I do to edit the wiki page and/or send a PR?
from webpack-book.
HI @henriquea,
It should be open to everyone? You just edit the page and save :-) ... or did we lock it?... yes we did. I have opened it now :-)
from webpack-book.
@christianalfoni done! https://github.com/christianalfoni/react-webpack-cookbook/wiki/Loading-SVG
By the way, the big downside of the Wiki is not be able to send PR's. Are you planning in change this structure?
Feel free to close this issue.
Cheers 🍺
from webpack-book.
@henriquea Yeah, lack of PRs is a bit unfortunate. We could work around this by moving the content the main repo, closing the wiki to modifications and setting up some process to update wiki content (it's a git repo after all...) and push new builds to gh-pages.
If that sounds fine, I could probably set up that on a Raspberry Pi I have around (just cron to trigger the process a couple of times per day or so). I have a setup like this for another project.
from webpack-book.
That sounds awesome @bebraw. The wiki gives such a nice structure, but hard to keep it consistent if everybody can just change it. So yeah, some pull system for it would be great!
from webpack-book.
@bebraw @christianalfoni agree with the lack of PR, move the wiki to the main repo makes a lot of sense for me.
from webpack-book.
I set up build/deployment scripts and made my raspi to perform updates once per hour (xx:30).
@christianalfoni Can you make the wiki closed to public again? All changes should go through the main project.
Let me know if you notice any issues (missing updates etc.).
from webpack-book.
@christianalfoni You should modify project homepage to point at https://christianalfoni.github.io/react-webpack-cookbook/ so it's easier to find if you stumble on page.
from webpack-book.
You mean in README of repo? pointing to wiki? Updated that now :-)
from webpack-book.
@christianalfoni I mean repo. That blank spot at next to A cookbook for using webpack with React JS
at https://github.com/christianalfoni/react-webpack-cookbook index.
from webpack-book.
Updated now, you mean like that? :-)
from webpack-book.
@bebraw @christianalfoni should we close the wiki and maybe delete its content?
from webpack-book.
@christianalfoni Here:
@henriquea It's enough to close it to modifications. I set it up so that the wiki content gets generated based on the repo.
from webpack-book.
Haha, I was not aware of that feature! Will fix it now :)
from webpack-book.
@christianalfoni Can you close the wiki for modifications? Just saw an edit there which I had to move manually to main repo since it would get overwritten.
from webpack-book.
Closed :-)
Do we have some documentation on how to contribute?
from webpack-book.
Do we have some documentation on how to contribute?
Not really. I suppose we should add something to both project root readme
and content/readme
. The workflow should go through PRs.
from webpack-book.
Yeah, I think that would be great. Just put it right there at the top. How does it work really? You fork and change the files in content/
?
from webpack-book.
Yeah, I think that would be great. Just put it right there at the top. How does it work really? You fork and change the files in content/?
Exactly. I'll add a snippet about this.
from webpack-book.
Related Issues (20)
- Enhance section on Hot Module Replacement HOT 7
- Purifying CSS when using React HOT 1
- request to translate into Indonesian HOT 1
- webpack 4 HOT 8
- Autoprefixing missing sample HOT 3
- Error on annotate-console-log syntax and annotation problem HOT 4
- Copybody Corrections HOT 2
- extract-text-webpack-plugin doesn't extract a file HOT 2
- developing - images directory had incorrect path HOT 1
- report one code error HOT 1
- building - tidying up - [email protected] replace default export with named export HOT 2
- favicons-webpack-plugin outdated dependencies HOT 1
- ew HOT 1
- Feed back and suggestions HOT 3
- Separating CSS: Code not working HOT 3
- WebSocket connection to 'ws://[::]:8080/wps' failed HOT 2
- in safari, not passing host fails the live reload of code HOT 2
- dynamic import about terser error HOT 16
- "watch" script throwing an error HOT 4
- css-loader now supports absolute imports
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpack-book.