Supertux does not compile due to missing header about supertux

[tobbi]

Can you add #include <algorithm> to the top of the file src/editor/object_settings.cpp and see if that fixes it?

[tulpenkiste]

Can you add #include <algorithm> to the top of the file src/editor/object_settings.cpp and see if that fixes it?

Just tested this on my end, adding this include fixes the problem

[biggeryetbetter]

Can you add #include <algorithm> to the top of the file src/editor/object_settings.cpp and see if that fixes it?

Yep, this fixes it. Do you want me to make a pull request for this or would you be able to just commit it straight to master? This is a pretty trivial change.

[tobbi]

Sure, just make a pull request. One less thing for me to think about.

[tobbi]

I don't quite understand how I've never experienced this bug on my system before.

[ztianyang]

I don't quite understand how I've never experienced this bug on my system before.

I think this is because of the version of gcc being used. The latest version of gcc on my Arch Linux system is 14.1.1. I recently experienced a similar issue when compiling Minetest 5.8.0, and I worked around this issue by installing the gcc13 package and using g++-13 as the c++ compiler. I was able to replicate this error in SuperTux using gcc 14. This error does not appear when I use gcc 13.

[biggeryetbetter]

I was able to replicate this error in SuperTux using gcc 14.

I'm also running an Arch system and sure enough, I've got GCC 14 installed. I wonder if something changed in how it handles transitive includes.