make install fails about supa_audit

[olirice]

I was not able to recreate this error

Here's the output for me (macOS 12.2.1, postgres 14.2 installed via brew)

Please note that supa_audit is a postgres 13+ extension only. If you could create a reproducible case against 13+ in a docker container (or other reproducible env) I'd be happy to help you debug

Also, you may want to add some requisites for this, namely, that the PG development package needs to be installed first.

The readme assumes some familiarity with installing postgres extensions and skips the default requirements but if you'd like to update the readme with more complete install instructions I'm game to merge it!

[MichaelDBA]

Wow, didn't know it is only for PG13! Why is that?

[olirice]

it is currently compatible with 12 but we're targeting 13+ to keep the maintenance burden down for future updates

[MichaelDBA]

What breaks in v11 or v10?

[MichaelDBA]

I actually tested it successfully for v11. It does break for v10 though.

Also, please add as a pre-requisite for installing that you need the PG development package installed beforehand. For CentOS it is something like this: postgresql13-devel.x86_64

I would suggest you make it supportable for V11+ since it works for all of them now.

Back to the original issue, make install error:
There is no error when compiling for PG v13, just for v11 and v12. Although both v11 and v12 work since it successfully copied the extension to the PG extension directory.

just that weird error where it is trying to do another mkdir -p without specifying a target directory.

[olirice]

I would suggest you make it supportable for V11+ since it works for all of them now.

you're welcome to use it on 11 and 12 at your own risk but we're going to stick with only officially supporting 13+ to avoid unknown issues like the make install problem you're currently seeing against pg 12

[MichaelDBA]

wish I was a make expert so i could figure out how or why that mkdir without a target is happening. Probably something easy to fix and the fix would seem to be worth being able to say this tool supports v11+. But again, it does everything its supposed to do even with the error.

[MichaelDBA]

I updated my distro, yum update. Ran the make install again for versions 11,12 13 and this time I did not get any make install errors! Don't ask me why.

Do you think you could now relent and make this tool supportable for versions 11+? There are tons of folks that wont be on v13 for years. Tools are very appealing when they support most of the Supported Versions of PG. I want to convince some of my clients to use this tool for auditing. But they are on older, but still supported, versions of PG.

I understand why you might not want to support v10 since it would require a major rewrite since it does not work as currently coded.

[darora]

Hey Michael-we're unlikely to take on the burden of officially supporting PG11/12 for this extension at this time.

[MichaelDBA]

by the way i am getting that same make install error again, but if do this, it doesnt error out:
make install USE_PGXS=1 with_llvm=no