Comments (13)
Hey @He1nr1chK, we'll be working on this next! Stay tuned!
from gotrue.
Hey @Seanmclem, I'm not too familiar with Expo Auth Session but I'll do up a v1 and we can see how to improve it from there!
from gotrue.
Hey @Seanmclem, thanks for bumping this issue. We know this is an important task - we are even hiring people to help with it. Our team is stretched extremely thin right now.
As a small note, the community functions a lot better when it's collaborative rather than accusatory. I understand if you have no time to contribute so a good way to help is to push other developers here who have the time/skills to help solve it. That way, everyone wins. If you know a good Go developer who can solve this - please let them know that we will send them swag if they can submit a PR.
from gotrue.
Hi @kangmingtay, thanks for all the great work. I just saw your PR for apple authentication. The problem that I think @Seanmclem is referring to is the fact that there is no practical way for us to use the implemented apple auth provider (or any third party provider for that matter) in React Native (or Flutter I assume). The issue, as touched on in this thread, is that the redirects do nothing when calling supabase.auth.signIn()
. The call just returns null for both session and user. From what I have gathered, the crux of the problem lies in RN (or Expo in my case) not having a way of handling the redirect as it is currently implemented. The solution suggested in the above mentioned thread is to expose a function for all third party providers to sign in by passing an access_token to the Supabase signIn()
method and then getting the user's data back. This is the way that Firebase handles the sign in for Expo. What are your thoughts on this?
from gotrue.
If I understand the linked thread correctly then we should be able to call /callback directly with the relevant access_token etc.
Is there any issue that tracks this? It is a very useful feature for mobile applications where a native Google / Apple sign in dialog can be shown to the users. Those dialogs already obtain a valid access_token that could be sent to the backend.
from gotrue.
Thanks for creating this @infomofo - this will involve and update to GoTrue.
I've labelled this as a Hacktoberfest task - let's see if anyone in the community wants to try solving it this month.
from gotrue.
Hi, any word on when this might be implemented. Can't use Supabase auth for iOS apps as Apple requires developers to add the "Sign In With Apple" option. Thanks @kiwicopple. Would do it myself but I am completely unfamiliar with GoTrue.
from gotrue.
looks like this is what we want:
https://developer.apple.com/documentation/sign_in_with_apple/generate_and_validate_tokens
https://medium.com/identity-beyond-borders/how-to-configure-sign-in-with-apple-77c61e336003
edit:
seems that:
"client_id: The application identifier for your app." i.e. .
"client_secret: A secret generated as a JSON Web Token that uses the secret key generated by the WWDR portal." use the private key to issue this JWT
can both be obtained here: https://developer.apple.com/account/resources/identifiers/list/serviceId
from gotrue.
Hi @awalias, looks good. I also found this repo that has already implemented sign in with apple written in GO: https://github.com/Timothylock/go-signin-with-apple
from gotrue.
Hi @kiwicopple @awalias, any update on this? I see that Twitter was just added as a OAuth provider. Can't use any third party providers on iOS if we don't provide sign in with Apple as an option
from gotrue.
Might difficult to use in an App without the ability to use with Expo Auth Session or something similar. Any idea if that will work?
from gotrue.
Hey @Seanmclem, I'm not too familiar with Expo Auth Session but I'll do up a v1 and we can see how to improve it from there!
Thanks. I guess I was just saying without a functional app implementation for supabase-auth, the Apple sign in would be less useful.
from gotrue.
If I understand the linked thread correctly then we should be able to call /callback directly with the relevant access_token
etc.
we also added the ability to redirect to deep mobile links using "Additional Redirect URLs", I believe it's being used on flutter already: supabase/supabase-dart#20
closing this now as I don't think there's any additional backend work required?
from gotrue.
Related Issues (20)
- `signUp` leaking existing user role HOT 1
- Internally inviteUserByEmail is not reading .data.custom_value when sending invitation email. HOT 1
- Using @supabase/ssr leads to endpoint issues HOT 1
- how to solve it? HOT 1
- OAuth redirecting to supabase dashboard HOT 2
- Cross-Origin Refreshing of `provider_token` is not allowed under OAuth HOT 3
- AuthApiError: Error sending confirmation mail HOT 11
- Account linking queries do a sequential scan on the users/identities table by default in managed Supabase HOT 3
- Users table index on recovery_token is not being used in queries HOT 1
- Apple Sign On: [AuthApiError: Bad ID token]
- Apple Sign On: [AuthApiError: Bad ID token] HOT 49
- Supabase auth for case sensitive emails HOT 3
- Auth hooks updates signed access_token, but not REST response. HOT 10
- `token_revoked` with large-ish `raw_app_meta_data` HOT 8
- Github Access Token Invalid HOT 1
- RedirectTo Recovery Path Stripped When Using Localhost HOT 2
- Only the information requested by the scope is not imported. and not response phone_number data HOT 9
- Index for refresh_tokens on deletion by user_id not used properly HOT 2
- Using PKCE flow forces you to use your provider client secret when refreshing the provider token HOT 1
- Handle 400 error from supabase.co/auth/v1/callback with a redirect to an error page HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gotrue.