Coder Social home page Coder Social logo

Comments (3)

Suor avatar Suor commented on August 15, 2024

You manually send post_save signal but don't pass all it's params. I don't think this is good behavior. Sending this internal signals yourself might be dangerous at all.

from django-cacheops.

rez0n avatar rez0n commented on August 15, 2024

The problem I raising that these params are optional for sender, but cacheops (actually seems it's dependency funcy) forcing params to be mandatory, which is unexpected behaviour.

from django-cacheops.

Suor avatar Suor commented on August 15, 2024

I don't think there is such thing as optional parameters to Django's built in signals. Any receiver may count on all documented params to be there. Nobody but Django itself is supposed to be sending them anyway.

If you do you are already on a dangerous territory and you are responsible to make your code to behave exactly like Django does.

Sure this might be fixed in cacheops but then any other signal handler might be broken the same way. And fixing it in cacheops will require it to make some assumptions, i.e. if using is not passed what does it mean? This is not a right place to resolve such questions.

from django-cacheops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.