Coder Social home page Coder Social logo

Comments (4)

sunny avatar sunny commented on July 23, 2024

Thank you for bringing this up! That's an error, rake should not be packaged inside anyplayer or sonice.

from so-nice.

sunny avatar sunny commented on July 23, 2024

Version 2.2.1 was released to fix this 🎉

even if I don't understand the "voting system"

Yeah, it's not very explicit, but it's a way to skip a song after several people decided to vote against it. You should disable it if it’s not useful to you.

and the artist picture is missing

Yes, unfortunately last.fm’s API doesn’t provide the photos anymore. Hopefully that PR gets merged soon.

Thank you for feedback, @Saroumane :)

from so-nice.

Saroumane avatar Saroumane commented on July 23, 2024

Yeah, it's not very explicit, but it's a way to skip a song after several people decided to vote against it. You should disable it if it’s not useful to you.

Yes, I get it but when/how the skip decision is handled ? I guess web clients can cast their vote anytime, but even after reading the code I don't understand if there is a threshold value that triggers the skip. (No offense, your code is probably well presented but I never used Ruby :)

Use case : 2 sonice web client connected. Can it be configured so that the current song is skipped as soon as 2 "skip votes" are casted ?

from so-nice.

sunny avatar sunny commented on July 23, 2024

Yes, there's a threshold of 5. No offense taken, the threshold is a constant inside anyplayer… so really not ideal.

This is definitely something that could use some configuration, e.g. SONICE_VOTING_SKIP_AFTER=2.

from so-nice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.