German card texts missing from most Adventures cards about dominiontabs

[wvoigt]

Yes, there are many cards that need translations. Hopefully with the update, some will come forward to help with that.

[sorawotobu]

I can type up German translations, just tell me which cards and where/in what format to submit them.

[wvoigt]

@sorawotobu The de language files for the v2 work is located here.

A better way is to copy them locally for editing. Go to our working branch Card-DB-refactoring, look for the green button on the right that says "Clone or Download", clicking it gives the option to download a zip file of everything for that branch. The files are in /card_db/de

Instructions are in the file translation.txt. The key is that any field that you translate, you want to remove that field name from the "untranslated" field. Otherwise the maintenance program does not know that you translated the field and will substitute the en_us for it the next time it is run.

If you need help just let me know.

[wvoigt]

@sorawotobu I just updated the de language files again. If you haven't started, you should be fine. If you have, let me know and I can help with fixing things.

[sorawotobu]

Just started with the translations, I noticed that I don't have permission to upload once I'm done. So what do I do then? Also, the German cards use special icons for the -1 coin and -1 card tokens. Is there a way to represent those?

[nickv2002]

@sorawotobu We don't have existing graphics for the -1 coin and -1 card tokens, so without new code and graphics there won't be a way to represent those. Might be best to save this for a second pass if @wvoigt is willing to code the symbols in and we can find a good scan of them.

The proper way to submit your changes is a pull request but that's tricky if you don't have experience with software development and Git. Instead, if you can put them up on a Gist, we can grab the text from there.

[wvoigt]

@sorawotobu and @nickv2002 If we had the symbols, it would not be too hard to add special codes for them. I recently added special codes for larger coin, VP, and Potion symbols.

[sorawotobu]

I had sort of forgotten about this, but today I finished up all the descriptions for cards and events and the extras for all the cards and half the events (because oh boy are the German additional rules wordy). May do the rest if I'm ever bothered by the fact that it's only half-done, but for the time being you can use this: https://gist.github.com/anonymous/d19fce4c69a8e751e08c93d8b898e3bc

I stuck to the exact wording and formatting in the German rulebook, however some of those rulings are poorly worded or even wrong, any suggestion what to do about that?

[sumpfork]

Hi @sorawotobu, are you working from the current https://github.com/sumpfork/dominiontabs/blob/master/domdiv/card_db/de/cards_de.json? It looks to me like a bunch of this work is already done and you're going back to English in some places? It'd also be a lot easier for us if you can make a pull request so we can see the diff to the current easily on GitHub. Thanks!

[sumpfork]

Closing this as there's been no activity and we already have lots more German translation in. Can reopen if there's more to talk about here.