Comments (4)
@PatrickJuergens Thanks for reporting!
Something like the ORMException
is unexpected and is not something we should use catch
on it. If I understand correctly the $item['taskId']
returns a uuid
which is not longer in the database. Then I think the TaskRepository
should throw a TaskNotFoundException we could catch here as we should not run into a ORMException in any case. /cc @wachterjohannes what do you think?
from suluautomationbundle.
Yes, $item['taskId'] returns an ID that no longer exists in the database, a TaskNotFoundException caught in this case should solve the problem.
from suluautomationbundle.
I think this need then be implemented here: https://github.com/php-task/TaskBundle/blob/dec507fa2143cf6205267f382cb053bf1b42a4c8/src/Entity/TaskRepository.php#L35-L38 that it throws a exception when the entity does not exist. So I think instead of using find
which just returns a proxy reference object. It actually should query and then throw the new Exception. Which we then can catch in the automationbundle. Do you wan to create a PR for this?
from suluautomationbundle.
Yes, I'll try.
from suluautomationbundle.
Related Issues (16)
- No permissions throw an error on the page HOT 1
- CMS doesn't take into account GMT timezone correctly when saving task time HOT 2
- Overview and bulk functionality HOT 1
- Missing disabled state for past tasks in ListView HOT 1
- Number with active tasks HOT 7
- Add link to sulu-documentation
- Missing Save-Button Task Information HOT 3
- Add translations to crowdin HOT 2
- SuluAutomationBundle 2.0 Roadmap
- Server error when navigating from page to contacts HOT 2
- Documentation for implementing automation for a custom bundle
- Save button still active after page has been published by automation HOT 3
- Attempted to load class "AutomationViewBuilder" from namespace "Sulu\Bundle\AutomationBundle\Admin\View". Did you forget a "use" statement for another namespace? HOT 1
- Clearing cache when {host} is used in webspace.xml
- SuluAutomationBundle's main.js is not loaded due to wrong path HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from suluautomationbundle.