Coder Social home page Coder Social logo

Comments (4)

alexander-schranz avatar alexander-schranz commented on July 17, 2024

@PatrickJuergens Thanks for reporting!

Something like the ORMException is unexpected and is not something we should use catch on it. If I understand correctly the $item['taskId'] returns a uuid which is not longer in the database. Then I think the TaskRepository should throw a TaskNotFoundException we could catch here as we should not run into a ORMException in any case. /cc @wachterjohannes what do you think?

from suluautomationbundle.

PatrickJuergens avatar PatrickJuergens commented on July 17, 2024

Yes, $item['taskId'] returns an ID that no longer exists in the database, a TaskNotFoundException caught in this case should solve the problem.

from suluautomationbundle.

alexander-schranz avatar alexander-schranz commented on July 17, 2024

I think this need then be implemented here: https://github.com/php-task/TaskBundle/blob/dec507fa2143cf6205267f382cb053bf1b42a4c8/src/Entity/TaskRepository.php#L35-L38 that it throws a exception when the entity does not exist. So I think instead of using find which just returns a proxy reference object. It actually should query and then throw the new Exception. Which we then can catch in the automationbundle. Do you wan to create a PR for this?

from suluautomationbundle.

PatrickJuergens avatar PatrickJuergens commented on July 17, 2024

Yes, I'll try.

from suluautomationbundle.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.