Comments (3)
I'm wondering about the architecture of this, in terms of the function calls for each event and where to define the shortcuts:
- Where to define: I think it's best to keep shortcuts for each action along with the component that currently provides this functionality. Keeping similar concerns in one place would be better than having one giant global file for shortcuts
- Function calls: should the store provide a method for those actions, which components and hotkeys can both call? Or the hotkeys can call the same function the component is defined with?
It really helps to write this kind of concern out, and this is something (software architecture, I guess) I really want to learn the best practices of
from qawl.
Oh as for function calls: I'm doing click calls on the visual elements 😅… part of me thinks this is bad practice, but another part thinks this will make it really easy to show those click and focus states on all the components when the relevant method is called (just like on old Qawl!)
from qawl.
Closed by #46 :)
from qawl.
Related Issues (20)
- Make narrower command bar HOT 1
- Trigger command bar less sensitively
- Increase padding at the bottom of the page (so there's space for the command bar) HOT 1
- Leave electron-builder HOT 1
- Quick global search HOT 1
- Make command bar draggable HOT 4
- Bookmarks + star feature HOT 2
- Consider analytics
- Add code signing or similar for all platforms
- Re-think buttons in command bar and overall UX HOT 2
- Make "download new update" second option in update prompt so it's not the default
- Update notification prompt should go to qawl site not github HOT 1
- Support more increments of the Quran (like juz, hizb, ruku') HOT 1
- Debug keyboard shortcuts
- support for 13 line version and different fonts HOT 6
- Process 13 line indopak mushaf PDF
- Include translation in app HOT 1
- Failed to launch HOT 3
- Package as Flatpak HOT 2
- What font was used in the Qur'an app? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qawl.