Failed to apply patch: 0004-fix-ipaddress-syntaxwarning.patch about pkgbuilds

[sudoforge]

Huh, that certainly is odd -- the code that handles patching doesn't specify any particular filename, instead preferring to dynamically apply all patch files that it finds in src/. I chose this method to simplify applying patches, but it looks the lack of specificity here is causing an issue in your environment.

Since you're using makepkg directly, I think the likely issue here is that you haven't cleaned the src/ directory from the last time you built, which would have been prior to fc6cf9f, which removed that particular patch file.

From man makepkg:

OPTIONS
       -c, --clean
           Clean up leftover work files and directories after a successful build.

       -C, --cleanbuild
           Remove the $srcdir before building the package.

Providing the --cleanbuild option should help get you moving now, and adding the --clean option to your future commands should help prevent this issue when building google-cloud-sdk and other packages.

[sudoforge]

Let me know if that helps!

[sudoforge]

Here's a bulleted guide to reproducing this issue:

• Clone this repository: git clone https://github.com/sudoforge/pkgbuilds.git
• Checkout the last revision with the patch file: git checkout d56aa760e84b32d84286e0be563bf5d9a0266b8d
• Move to the package directory: cd google-cloud-sdk
• Build the package (-s to install deps): makepkg -s
• Switch to any newer revision: git checkout origin/master
• Build the newer version: makepkg -s

This reproduces the error, as expected, because the src/ directory is not clean and still contains the 0004-fix-ipaddress-syntaxwarning.patch file. Using the -C or --cleanbuild flag cleans the src/ directory before building the package, which avoids this issue.

It would perhaps be better to explicitly pass the appropriate patch filenames to the patch command, at the cost of maintenance ergonomics -- it would avoid issues like this, but ensuring that the build environment is clean isn't really the job of the PKGBUILD. I'm going to close this for now, but feel free to comment if the issue persists for you.