Comments (5)
Hey I was hoping to contribute and tried working on this issue but it seems this may require changes in substance or ui repo? I was hoping to simply copy the functionality of the link.js which is inherited from Document
like how Emphasis and Strong are inherited. I was able to add the tool component to content_toolbar.js and then enable it in the ENABLED_TOOLS
in content_editor.js. However it seems the styles are not available at least not in how they are being referenced right now.
For example, the prose-editor demo uses the link tool and it seems to be grabbing its styles from writer.scss under the substance/ui folder where it imports link.scss.
However in the lens-writer app, it seems to be referencing the styles from the ui repo where it has its own writer.scss file that does not include the link styles.
It seems the package.json is referencing an old version of substance which does not have the bundled ui folder which is why they are treated separately
"substance": "substance/substance-legacy#193d87259fae45a0f546bdb133a9fc7f34d87b52",
"substance-ui": "substance/ui#7a6cb53b1d6a1e55fa022c2b69a1b8f938f5ae4f"
Is there a reason why lens-writer is referencing older versions of the packages and why it would need these packages separated? Just curious :) this is an awesome project!
from lens.
Lens-writer is in a prototype state. After this we took the lessons learned and tried to make substance better. Now the step back is missing, i.e., bringing lens-writer back on the substance main track.
However, good news, we are working on that the next weeks. So likely by end of this month this is done.
from lens.
@oliver---- Ah gotcha. Sorry didn't realize. Looking forward to the final result :)
from lens.
Cool you like it. I ping you when it is done :)
from lens.
@augbog This is fixed now. You can run the latest dev version by checking out the #edge branch. However, still don't expect it to be stable.
from lens.
Related Issues (20)
- When a cursor moves into a reference, it can't move out of it anymore HOT 2
- npm install fails on 'fix-lens-#96' HOT 1
- Figure insert before existing figures doesn't change figure numbers HOT 1
- Using cite after selecting a block of text replaces the entire text HOT 2
- Copy-pasting rich text within the document is not working
- Use self-hosted iframely service
- ScrollTo is not accurate anymore HOT 1
- Fix updating of citation targets HOT 1
- Overcome missing Node lifecycle hooks
- JATS Import/Export HOT 15
- Fix bib item panel styles HOT 1
- Embed import/export not working properly
- Citation labels are not computed correctly.
- When cut'n'pasting a figure, figure citation labels get screwed.
- Read mode is broken? HOT 1
- Search bib ref not enabled?
- Abstract is missing from the saved XML
- Undo does not re-enable save button
- Inserting an image fails silently HOT 1
- Using left, right arrow keys to navigate text around citations messes things up HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lens.