Comments (2)
Was looking p2pt over to use in one of my projects and thought I'd drop a question or two that might help while you are doing this re-write to modernify.
1. Why not extend bittorrent-tracker
's client instead of re-implementing much of its logic?
It looks like p2pt is a custom client that is passed over to the trackers. But when you start looking at the client implementation that bittorrent-tracker
has and p2pt
's implementation, there is overlap.
To point a few out, _defaultAnnounceOpts
, _announce
/_fetchPeers
, getTrackerStats
/scrape
, setIdentifier
/constructor
.
There's a few more overlaps here and there. Not trying to say rolling completely custom isn't the way to go since we don't need the other tracker types but was wondering about that.
from p2pt.
@RonaldZielaznicki I don't exactly remember the reasons but I think it was because of the difference between the usecases. I guess I didn't want to carry all the methods from bittorrent-tracker's client.
from p2pt.
Related Issues (20)
- Issues connecting with Peers on Different Networks HOT 8
- Possibility to destroy only tracker connection and not peer connections HOT 1
- Slow tracker connection HOT 1
- Does not connect to peer when using multiple trackers HOT 1
- Codepen example no longer works HOT 1
- can you do video streaming? HOT 1
- Tracker-swarm to help with low quality public tracker servers HOT 2
- How to send files? HOT 2
- BTorrent tracker url is wrong HOT 1
- add peer
- 同学,您这个项目引入了674个开源组件,存在7个漏洞,辛苦升级一下
- Unexpected behaviour when bundled by Vite (and likely WebPack and other bundlers)
- addTrack to peer connection
- Consider switching from randombytes to some other dependency that does the same thing HOT 1
- Bump bittorrent-tracker dependancy due to WebRTC URL handling changes in Chromium v110 HOT 1
- Hello Mr Decentralized 🙏 HOT 2
- Chrome and Spinoffs eg. Edge not working HOT 2
- TURN Server and ICE Candidates HOT 2
- How to "Auto discover devices in the same network (LAN)"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p2pt.