Comments (13)
Hi,
For Github OAuth to be happy, all the URLs must match - the URLs in the config.js and the Github OAuth application. Common culprits for mismatch are the protocol (http vs https).
Please verify they all match up.
from strider.
They seem to match:
config.js contains:
// Server URL on the Internet
var sm = exports.strider_server_name = "https://strider-topicus.herokuapp.com/";
And Github app contains:
https://dl.dropbox.com/u/6675617/Screen%20Shot%202012-11-06%20at%2011.46.42%20.png
from strider.
Tested both http and https on all vars
from strider.
Can you try removing the trailing slash in the server name and seeing if that fixes it?
e.g.
var sm = exports.strider_server_name = "https://strider-topicus.herokuapp.com";
If that solves the issue, we can patch Strider to be less brittle in this regard.
from strider.
Indeed, that is the problem. I will not close it, seems to me you should fix this :-)
btw. now it works like a charm, first build + deploy is a fact, awesome work
from strider.
Yep, will definitely fix. Acknowledge the setup process is more annoying than it could be. I am working to improve this (web-based installer).
Glad Strider is working for you!
from strider.
This seems to be a redirect_uri_mismatch - is fixing this as simple as stripping the trailing slash where it is used in auth.js?
from strider.
Probably. Can you check the value of exports.strider_server_name
in config.js on Heroku? (heroku run cat config.js
or similar)
from strider.
Not sure I follow you... The contents of config.js
in heroku is identical to what is commited to the repo. When the github connection breaks, strider_server_name
has a trailling slash, and when I remove it, all is good.
I'm pretty sure I'm missing your point 😄
from strider.
I removed the trailing slash from config.js in master a moment ago. The web installer should write a value without a trailing slash, too.
So I just wanted to verify that was indeed the cause of your problem. Thanks for confirming!
from strider.
Ahh, got it. By the way, I used the manual install process (just so I could learn how this is all working). I'm just about to do a pull request that simply does a .replace(/\/+$/,"")
to kill trailing slashes on line 115 in auth.js - this will handle the situation when someone changes the config manually. Or is that not a good idea?
from strider.
👍 +1 Yeah, I think that change definitely makes sense
from strider.
Ok, testing it out. Keep your eye out for a pull request.
On 25 January 2013 00:15, niallo [email protected] wrote:
+1 Yeah, I think that change definitely makes sense
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-12691722.
from strider.
Related Issues (20)
- Cancelled Deployment = Cannot Deploy Anything - UnhandledPromiseRejectionWarning HOT 2
- After upgrading to 2.0: Failed to load template: build-tpl.html HOT 6
- Modernizing the strider stack HOT 1
- Strider won't install HOT 6
- Strider can't access organisational repositories HOT 3
- Build fails: Cannot find type definition file for 'express-session' HOT 5
- Failed to lookup view HOT 9
- Deprecate strider.json merge_plugins option HOT 3
- 500 TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined HOT 4
- Audit calls to debug
- 500 TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined HOT 4
- Config to change default branch name HOT 1
- Installation instructions need updating HOT 2
- Fonts and ssl HOT 3
- [Feature Request] Add support for gitea SCM HOT 1
- screenshots are broken in wiki screenshots page HOT 1
- several vulnerabilities CVE-2020-15168,CVE-2020-7598 are introduced in strider HOT 1
- Unable to run scheduled jobs on Katalon Testops - Error: spawn git ENOENT
- Missing license HOT 1
- Same SPN usage in different projects - Azure DevOps HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strider.