Comments (32)
I implemented showing a warning on entering a not-really-slower-than-normal speed limit in the slow-zone sign input, also shown for odd values such as "17" etc.
from streetcomplete.
Sorry, missed a : in there.
Actually, if a user types in 19, a message will come up saying "Are you sure? This speed limit looks implausible", so there is a level of prevention that needs to be applied to the 30 value, just with a different message perhaps - users may not understand exactly how 30 mph speed limits should be tagged
from streetcomplete.
so there is a level of prevention that needs to be applied to the 30 value, just with a different message perhaps
note that 30 in such case would be wrong only in UK
is it problem with single user? or more wide?
from streetcomplete.
Three users in the past few days
https://www.openstreetmap.org/changeset/150269316#map=18/50.69686/-2.10863
https://www.openstreetmap.org/changeset/149670842#map=14/50.4130/-4.2552
https://www.openstreetmap.org/changeset/150346330#map=19/51.64014/-2.35272
https://www.openstreetmap.org/changeset/149992725#map=18/51.74024/-2.22937
from streetcomplete.
This is not a bug. It is what the user(s) selected. The following video shows what the user has to select and input in order for this to be tagged:
Maxspeed.mp4
I.e. the users answered that it is within a slow zone and a picture of the sign was shown for them to input what they see on that sign.
from streetcomplete.
Sigh... it seems I fail in bringing across what I want from you.
I am not going to add special rules in the code for every single country code, like if (country == UK && input == 30) showWarning()
because this approach would just be an endless source of similar requests: What about an input of 29 or 31? What about Jersey (not part of the UK)? What about input of 50 (etc?) in non-mph-countries? What about the US, Liberia? What about..., what about? That's busywork. I want a solution that covers all.
Anyway, I can think of something myself, but then I would like to know from you why especially the input of 30 is that common of a mistake in the UK? You started changeset discussions on some of these changesets, so hopefully the users will be able to answer this.
Without understanding why this mistake occurs, any proposed solution may just fail.
from streetcomplete.
Better automated solution might IMHO be that on-new-release we build a list of allowable
maxspeed:type
(e.g. by looking up all values which have 50+ (or whatever) uses, e.g. this taginfo for United Kingdom), and warn on anything not in the list
All those listed there, except maxspeed:type=construction
are the only tags that should be used in the UK (with the maxspeed:type=GB-WLS:nsl_restricted
only being somewhat adopted after a discussion on TalkGB). I recently spent time removing/fixing incorrect tags, hence why I brought this up in the first place.
Also, perhaps it might be useful to actually contact those users who mapped wrong non-existent values (esp. if they same user did that same error several times or more) and check with them why it might be happening? Sure, fat fingers are one explanation, but there might be others...
I did contact those who made the mistakes but the only reply thus far is a comment linking to this exact thread.
from streetcomplete.
I suspect because it's somewhat common to say "30 zone" to refer to general widespread 30 mph speed limits in the UK, and so these users selected the zone sign when answering the quest as a result. I didn't actually ask each user why they made this mistake, just a general comment on how to correctly tag such limits. I will add a question onto the end of each changeset
from streetcomplete.
Actually maxspeed:type=GBzone30
seems really bad, it should at least be maxspeed:type=GB:zone30
.
But otherwise it's on the user. If the user answers it's a zone with 19 kmh limit, then SC will tag zone19
.
from streetcomplete.
Could you link to some of the changesets in question? Have you already asked the user about this?
from streetcomplete.
Yes, I understand the process works as intended, but that should not be the case as a 30 zone does not exist in the UK. Only the tags maxspeed:type=GB:nsl_restricted
and maxspeed:type=sign
should be used with maxspeed=30 mph
.
from streetcomplete.
So, you would like us to add a sanity check alike the "this speed limit looks implausible, are you sure?" in regards to slow zones.
How do you think such a check should look like?
from streetcomplete.
Something along the lines of "Are you sure this is a speed limit zone? Please check you can see a speed limit zone sign"?
from streetcomplete.
from streetcomplete.
Well 30 is likely the most common mistake due to the way 30 mph speed limits work in the UK. A message for that input should be fine.
from streetcomplete.
Well, we need to think worldwide, because the quest is available worldwide. And surely, the same message should also be shown for an input of 31, 40 etc., no?
from streetcomplete.
Well, those are likely mistakes, whereas the 30 zone tag has been applied by multiple people, showing a bigger issue. I think the "Are you sure?" message covered by strange numbers is fine for the other values, it's just the 30 that appears to be the issue.
from streetcomplete.
But an input of 30 should not lead to a warning message everywhere in the world, right??
from streetcomplete.
Well, this is only an issue in the UK
from streetcomplete.
@westnordost alright, what about adding a positive list for existing zones per country and warn if the user inputs something else?
There's the default speed limit article which is supposed to be machine readable in the OSM wiki.
I think it could be extended to list the zones in each country (or this could be added in some other article) and imported into SC while creating a new version.
This way there's no need to maintain this data in SC.
from streetcomplete.
Maybe it can go into country data? And if there is list defined complain about ones outside the list.
from streetcomplete.
That sounds like a huge effort for a small "Are you sure?" dialog. (Not only initial, but also continuous - maintenance.)
Also, what hinders road authorities to come up with new limits for speed signs on the spot? 30kmh zone is well known, but I don't see a reason why there shouldn't be a 20kmh zone, a 10 kmh zone, a 15kmh zone, etc.
from streetcomplete.
Maybe it can go into country data? And if there is list defined complain about ones outside the list.
Yeah sure, but that would need continuous maintenance, compared to a wiki approach where people would maintain it for you.
from streetcomplete.
That sounds like a huge effort for a small "Are you sure?" dialog. (Not only initial, but also continuous - maintenance.)
Also, what hinders road authorities to come up with new limits for speed signs on the spot? 30kmh zone is well known, but I don't see a reason why there shouldn't be a 20kmh zone, a 10 kmh zone, a 15kmh zone, etc.
Germany already got 20 km/h zones... and there were 10 km/h π
from streetcomplete.
There's the default speed limit article which is supposed to be machine readable in the OSM wiki.
Perhaps I am misunderstanding, but how would that specific wiki page help @RubenKelevra ?
That page says it is about "Legal default speed limits apply if no explicit speed limits are set by appropriate signs". I.e. what is default speed limit for urban, rural, motorway etc. road if no sign is present.
If some kind of speed limit sign is present (i.e. maxspeed:type=sign
, maxspeed:type=CC:zoneXX
etc), I would guess that it is usually because the current street has speed limit which is different then those present in default speed limit wiki?
For example, when I count different maxspeed
s used in Croatia, majority of them are not present in that wiki.
And when I count different maxspeed:type
(to get zones, which this issue seems to be about) literally none of the Croatian zones (zone10
,zone20
,zone30
,zone40
) are present in default speed limit wiki. So, at least here, it would always give a confirmation warning for any zone (which would suck)? (that is, if I understood the idea correctly in the first place, which is not given π)
Better automated solution might IMHO be that on-new-release we build a list of allowable maxspeed:type
(e.g. by looking up all values which have 50+ (or whatever) uses, e.g. this taginfo for United Kingdom), and warn on anything not in the list, but:
- I have not checked if all countries have per-country taginfo database
- there is still the possibility that there be 50+ incorrect values on OSM at the moment of the release
- as noted by BDFL, I'm also not sure if the effort would be worth it.
I think SC does something similar for ATM operators, but that one saves a lot of typing and mistakes (but has same problem as point above -- if OSM has several variations of operator name, all of them will be present in the search. Which is currently the case in Croatia, for example. Mechanical edit would be relatively easy to fix them, but the sheer bureaucracy around doing that makes me postpone those fixes every time π’)
Also, perhaps it might be useful to actually contact those users who mapped wrong non-existent values (esp. if they same user did that same error several times or more) and check with them why it might be happening? Sure, fat fingers are one explanation, but there might be others...
from streetcomplete.
I did contact those who made the mistakes but the only reply thus far is a comment linking to this exact thread.
Ok, let's wait a bit. Did you actually ask them or have a hunch why they answered this way?
from streetcomplete.
Are these "30 zones" signed in some way or are they set implicitly by the presence of street lighting?
from streetcomplete.
Many of the incorrect tags were applied to 30 mph speed limits where there are no repeater signs due to the presence of street lights (where the correct tag is maxspeed:type=GB:nsl_restricted
) although one example was an unlit road (where the correct tag is maxspeed:type=sign
)
from streetcomplete.
So, would changing the wording to "It's within a signed (slow) zone" make it clear?
from streetcomplete.
Potentially
from streetcomplete.
The wording change was reverted in b89db4a.
from streetcomplete.
because looking at the translations, some are already a bit awkward, with that "(slow)" in there. Adding another adjective will result in even more awkward wording for some translations that may end up being confusing.
More importantly, adding the word may evoke the wrong notion that for a slow zone to be tagged as such, there needs to be a sign on that street, which is usually not the case with slow zones - there are only signs at the entrance and at the exit to such zones.
from streetcomplete.
Related Issues (20)
- When searching for Things in Things Overlay, show matched alternative name too HOT 4
- Trigger "medical laboratory" when "diagnostic" is searched (adding shops) HOT 5
- Text for "Other answer" instead displays as "ER..." HOT 1
- Ability to save edits locally HOT 6
- Add new quest: Is this smoothness still accurate? HOT 7
- Quest suggestion: Do the trees here have leaves all year around? HOT 1
- Improve Postman achievement description HOT 1
- Lamp mount HOT 4
- Caused by: java.lang.AssertionError: Dispatch receiver type de.westnordost.streetcomplete.quests.width.AddWidthForm is not a subtype of de.westnordost.streetcomplete.quests HOT 2
- tracktype/surface conflicts are confusing HOT 9
- Unable to edit amenity=post_box in "things overlay" HOT 3
- Use NSI data in preference to usage data for operators/brands HOT 7
- Additional answer (power=terminal) for PowerPolesMaterial-Quest HOT 11
- Cycleways overlay - Options to map - Clarification possible? HOT 12
- Old opening_hours=* seems not to be removed, if opening_hours:signed=no is set by StreetComplete HOT 2
- Quests for opening hours are also asked for zoo=enclosure marked as a zoo, within a zoo HOT 8
- Ask if benches have armrests HOT 7
- Highlight `traffic_sign=city_limit` when answering maxspeed quest
- Crossing kern height quest should not be asked for roads that have no sidewalks
- Add Type "Floor" to bicycle_parking type Quest
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from streetcomplete.