Comments (4)
Good find, thanks for sharing! I didn't contemplate people might want to develop their own sidebars. This is a limitation that shouldn't exist.
To be honest, the mechanism is a bit hacky as it is, and I think partially matching the string "sidebar" would be even hackier.
I'd prefer having something that tells the Page where to put it, whether it's the core Sidebar or a custom component. I'm thinking an additional attribute in the StreamsyncComponentDefinition
(in streamsyncTypes.ts)...
export type StreamsyncComponentDefinition = {
[...]
insertionArea?: "default" | "sidebar";
};
I believe this is cleaner and would allow us to develop e.g. "footer" or "topbar" in the future, without breaking anything.
Feel free to send a PR; it'd be appreciated. Should still be quite straightforward I believe. Apart from that change in type as shown above, I think it'd just be checking whether the component is c.insertionArea == "sidebar"
or not in CorePage.vue
. Please let me know your thoughts.
from streamsync.
Hi @ZBMO , can you please confirm whether you want to work on this PR? Otherwise we're happy to take it ourselves
from streamsync.
@ramedina86 sorry for the delay, I'd like to but I won't be able to work on it till next week. I understand if you need it done sooner.
from streamsync.
@ZBMO no worries at all, next week is fine. And of course no pressure, just want to avoid two people working on it at the same time.
from streamsync.
Related Issues (20)
- Fix docs video on mobile HOT 1
- Add Discord link to README and website HOT 3
- Add serialiser for Polars and Dataframe Interchange Protocol
- Repeater triggers exception when the last item is removed from linked state element HOT 2
- Slider width is not constant if it involves decimals HOT 1
- change on value of a graph as vega spec does not trigger mutation in extension HOT 6
- Python 3.12 tests issuing DeprecationWarning related to multiprocessing HOT 2
- use poetry instead of setup tools as package manager
- github action enforce PR continuous integration rules
- Changing font-family for entire app not intuitive
- Unable to build docker image with Dockerfile from docs HOT 2
- Event context not working for repeater objects where the repeater object is specified using square brackets "[ ]" HOT 2
- Serving large numbers of images
- pagination component documentation is missing on the official documentation
- Add checkbox column to dataframe that is interactive HOT 1
- Use Pydantic for automating most event payload sanitisers HOT 1
- Question: How to link message component with a state element HOT 1
- How to convert <streamsync.core.BytesWrapper object at 0x1065ca890> to base64
- Create separate test apps for backend and manual frontend testing HOT 1
- declare optional schema on streamsync state HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from streamsync.