Enable app native key binding for router component refresh on macOS about streamlink-twitch-gui

[bastimeyer]

Is there any reason why app native key binding is blocked on macOS?

I had a quick look and it seems like it's a remnant of the previous implementation, where hotkeys were not customizable.

Customizable hotkeys were added in aaf60cd.

If you take a look at the git-blame of the MainMenuComponent from the commit prior to that, you can see that the refresh callback was unchanged and just got moved when the customizable hotkeys were implemented:

• https://github.com/streamlink/streamlink-twitch-gui/blame/df73b7e2654af5b2dd519dab23ca61a824b6dbe0/src/app/ui/components/main-menu/component.js#L21-L26
• https://github.com/streamlink/streamlink-twitch-gui/blame/df73b7e2654af5b2dd519dab23ca61a824b6dbe0/src/app/ui/components/main-menu/component.js#L44-L48
• aaf60cd#diff-00e4acc8c9a2852c479064e5fae65d09e55455b62c624d68efff93e4ae235717

The if ( isDarwin ) { return; } block was added to the MainMenuComponent's refresh callback, because the macOS system menubar always gets added with the static CMD+r hotkey (due to convention), same as the CMD+, for opening the settings menu, so back then it was deemed redundant having the CTRL+r refresh hotkey as well.

• https://github.com/streamlink/streamlink-twitch-gui/blame/v2.4.1/src/app/nwjs/Menubar.js#L48-L54

---

Let's remove the isDarwin check.

Since you already had a look at the code, do you want to open a quick PR which removes the check and the comment above? This won't affect any tests, so it's just these two lines. If not, then I can apply the changes myself later.

[templateK]

Thanks for detailed answer. Let me know if there's anything needs to change on pr.