Coder Social home page Coder Social logo

Comments (7)

TrySound avatar TrySound commented on April 19, 2024 1

This component is implemented in wrong way. Batching and async doesn't work with it. State based updates should be done with function updater like setToggle(v => !v).

from react-use.

TrySound avatar TrySound commented on April 19, 2024 1

I said implementation is wrong. Not usage.

from react-use.

streamich avatar streamich commented on April 19, 2024 1

Thanks guys, added your suggested fix:

from react-use.

malerba118 avatar malerba118 commented on April 19, 2024

I'm using it as per the docs.

screen shot 2019-01-04 at 1 28 19 pm

The toggle function accepts one argument, an optional boolean, not a function.

screen shot 2019-01-04 at 1 27 57 pm

The whole point is to delegate toggling logic to the useToggle hook. If the toggling logic was required in the updater function, this useToggle hook would have no purpose. It would just be a no-op wrapper around useState.

from react-use.

malerba118 avatar malerba118 commented on April 19, 2024

Apologies, I thought you were referring to my implementation of it.

from react-use.

benneq avatar benneq commented on April 19, 2024

It's been released today. Is it working now?

from react-use.

streamich avatar streamich commented on April 19, 2024

I believe this has been fixed.

from react-use.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.