Coder Social home page Coder Social logo

Comments (4)

erikwrede avatar erikwrede commented on July 22, 2024

I believe this is by design and that there are two distinct cases of masking errors:

  • don't leak unintended error information on accident (current implementation)
  • don't leak private schema information (e.g. available fields) through validation

Both cases are valid and may be required on their own without implying the other case. Please keep in mind that both cases exclude parsing, but I don't see any immediate security risks from leaving these open.

An ideal PR would add your suggestion as a configurable option. Since this is a new feature, you could write an integration-style test with a basic schema and an invalid query that fails validation against the given schema.

Feel free to tag me on the PR regarding any additional questions, or ask on our Discord in the #development channel 😊

from strawberry.

alimony avatar alimony commented on July 22, 2024

@erikwrede A configurable option on the MaskErrors class, or e.g. a MaskValidationErrors subclass of MaskErrors?

from strawberry.

erikwrede avatar erikwrede commented on July 22, 2024

@alimony I'd prefer an option on the MaskErrors constructor. CCing @patrick91 for a second opinion.

from strawberry.

alimony avatar alimony commented on July 22, 2024

@patrick91 What do you think?

from strawberry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.