Comments (5)
dbartholomae
commented on May 26, 2024
1
Since the types of react-loadable are currently managed via DefinitelyTyped and I wouldn't want to couple this library to a helper library, I have also written a PR to DefinitelyTyped instead of this one. When it gets merged, types for react-loadable-visibility should be available from @types/react-loadable-visibility. The PR might take some time though since I have a problem with the typings of react-loadable itself that I currently cannot solve on my own.
from react-loadable-visibility.
tazsingh
commented on May 26, 2024
Of course!
…Sent from my iPhone
On Aug 23, 2019, at 9:05 PM, Daniel Bartholomae ***@***.***> wrote:
Hi there,
would you be interested in a PR that adds TypeScript typings?
Best,
Daniel
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from react-loadable-visibility.
dbartholomae
commented on May 26, 2024
Typings are available now via DefinitivelyTyped
from react-loadable-visibility.
tazsingh
commented on May 26, 2024
@dbartholomae Amazing! Thanks for getting that done
If you want to add instructions to the README on how to get that working, I'd be happy to review a PR that adds that in. Let me know as you'll likely get to it before I have a chance to
from react-loadable-visibility.
dbartholomae
commented on May 26, 2024
Shouldn't be necessary, it is the default way to add typings for repos that don't have typings, and TypeScript itself will guide you to it :)
from react-loadable-visibility.
Related Issues (20)
- Not working when component itself has more content to cover visible area HOT 3
- Undeclared dependency react-loadable HOT 1
- no declaration file HOT 4
- no declaration file HOT 1
- not working - file is fetched on page load HOT 13
- Enable IntersectionObserver options HOT 3
- Use the 'isIntersecting' attribute as a fallback for zero threshold HOT 1
- How to wait until fetches are complete before showing loadable component? HOT 1
- Enable setting minHeight and minWidth on placeholder div HOT 1
- update to @loadable/components package HOT 2
- Failed to execute 'unobserve' on 'Intersection Observer' HOT 2
- Remove props from placeholder div HOT 9
- can I use in react universal? HOT 1
- warning occur when use react-loadable-visibility,but react-loadable is ok HOT 5
- Not working with loadable SSR HOT 4
- window is not defined on server side HOT 2
- LoadableVisibilityComponent doesn't expose loadable's load function. HOT 2
- Is this SEO friendly? HOT 1
- Always render all contents during SSR? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-loadable-visibility.