Coder Social home page Coder Social logo

Comments (3)

kimcoleman avatar kimcoleman commented on June 1, 2024

We've updated the setting to say "Show Banner and Thumbnail" and are now only showing that setting option if the Multiple Post Thumbnails plugin is installed and activated.

This should help to combat any cases where the same image is displayed twice or thrice.

e4fb835

from memberlite.

ideadude avatar ideadude commented on June 1, 2024

We have decided to address this for v4.1 (or via a memberlite-elements update)

Roughly, when "show banner and thumbnail" is set in the customizer featured image option, we won't show the featured image as the banner unless the "show as banner" option is checked on the edit post page (by the featured image). If "show as banner" is checked here, we will NOT show the featured image as the thumbnail.

So...

When rendering the archive view of a post and the "show banner and thumbnail" global option is set:

  1. The banner is going to be first the specified banner image or if the "show as banner" option is checked on the featured image, use that as the banner.

  2. The thumbnail image is the featured image unless the "show as banner" option is checked.

from memberlite.

kimcoleman avatar kimcoleman commented on June 1, 2024

In re-reading this (plus considering new changes to the block editor) I realize we don't have "show as banner" setting anymore in the Featured Image settings panel on single post edit.

The user cannot currently set the featured image as the banner image and I don't think we need to support this.

I think the best check will be to hide the thumbnail if you have show_both as your setting BUT the Memberlite Elements plugin is not active. This is because you cannot possibly set the featured image to anything else without Memberlite Elements. I think this is a fine "fail safe" method to prevent double images. It should prevent triple images for sure, and most often double images.

from memberlite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.