Comments (6)
Oh interesting; I just saw this PFM issue on ibc-apps/issues
and thought "wrong place". Are we risking ibc-apps/issues
becoming a sludge pile of issues for a bunch of child repos?
@jtieri is there a pattern you like for dealing w/ this? A few ideas come to mind:
- everything in
ibc-apps
, and use labels to segregate issues w/in (CON: this could get messy) - everything keeps its home repo (and repo board) and is submodule'd into ibc-apps (CON: git submodule is a PITA)
Whaddya think?
from packet-forward-middleware.
My naive response would be that we sunset the child repos and move completely over to ibc-apps and explore using some sort of label system to filter down issues/prs for modules and middleware that we are the sole maintainers of for tracking in the motherboard.
With that said, I have no prior experience with trying to maintain a mono repo with multiple teams co-mingling. Someone else may have more valuable feedback here that is born out of experience and not intuition. My reasoning for wanting to sunset the child repos is that with two different repos it feels like more cognitive overhead as far as trying to respond to issues and PRs, not only that but it also feels like you will constantly be fighting the uphill battle of trying to educate users on where the appropriate repo is located for opening new issues vs. where you should be importing the software into your downstream projects.
I am fairly open minded here and could definitely be convinced that the latter option is better, I just have no experience with git submodules and so I think I'm lacking a clear mental model on what that really looks like and the implications that it bears.
from packet-forward-middleware.
Feels like "six of one, half-a-dozen of the other" to me; I don't have a strong bias.
Let's go with the 'everything in ibc-apps, and use labels to segregate issues w/in' strategy.
from packet-forward-middleware.
need to double check PFM repo tickets and reopen necessary ones into ibc-apps
Not sure what to do with old tags. @misko9 suggests we address these old tags before archiving PFM repo
from packet-forward-middleware.
forget about the old tags when moving tickets to ibc-apps
from packet-forward-middleware.
I have moved Issues to the new repo & closed here w/ linking
The CI / motherboard tag things should be a requirement upstream vs a requirement to archive this. We do not have enough issues yet to "need" to sort, but agree a label based CI system is needed.
releases have been done for major versions: https://github.com/cosmos/ibc-apps/releases
from packet-forward-middleware.
Related Issues (20)
- Hub routing idea HOT 1
- The name `router` is ambiguous given its usage in other contexts HOT 4
- v2.1.0 release module name HOT 3
- Update to v0.46 HOT 5
- Run tests in CI
- Add a simple binary for testing purposes HOT 2
- token gets lost when using unsupported destination address HOT 3
- The `router` module is not an IBCMiddleware HOT 4
- Status of the project. HOT 1
- Allow native JSON on the memo field
- Migrate to ibc-go v7 HOT 1
- Routing of ibc denom not working. HOT 12
- use cometbft HOT 1
- pfm depends on an older version of itself HOT 1
- Middleware panics when transferring tokens with 10^18 denom HOT 2
- Migrate PFM to `ibc-apps` repo HOT 4
- Test packet forward middleware with SDK alpha release
- bump packet-forward-middleware to cosmos-sdk 0.45.1 HOT 2
- PFM hook possible fixes when used along with IBC-hook? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packet-forward-middleware.