Coder Social home page Coder Social logo

Comments (14)

achtan avatar achtan commented on April 25, 2024 52

view source - yes
edit source - no

from storybook.

willdady avatar willdady commented on April 25, 2024 49

Not sure if this is what everyone else had in mind but I'd rather see the component's implementation, not the source code. If I wanted to see the source code I'd look at the source code. If my story looked like this:

storiesOf('ProgressBar', module)
  .add('25%', () => (
    <ProgressBar progress={0.25} />
  ));

I'd like to see <ProgressBar progress={0.25} /> rendered somewhere in the storybook. Maybe as a separate panel above the action logger, or a separate tab?

from storybook.

thani-sh avatar thani-sh commented on April 25, 2024 7

Fixed with this addon

from storybook.

ritz078 avatar ritz078 commented on April 25, 2024 3

I don't think we should go ahead with this idea at this moment. react-storybook shouldn't take the component development out of the application. We should edit real files because otherwise using this module will become as good as using codepen or jsfiddle. At the same time as long as we are using this for development and not for component display, we can use devtools to see source code.

from storybook.

jeef3 avatar jeef3 commented on April 25, 2024 3

I would actually start to wonder the value of seeing even the source inline (other than to make this a complete component IDE of course).

Instead, what do you want Storybook to become? So far it is a place for seeing the different states a component might be in, while also providing hot-reloading, ideal for development. Does Storybook then become a living styleguide perhaps? A library so other developers on your team can see what components are available and how to use them? If this is the case, then there might be value in not necessarily story source code, but example usage source code? Could this be extracted from the story somehow and displayed, maybe?

from storybook.

arunoda avatar arunoda commented on April 25, 2024 3

@stewartduffy using rawLoaders is a pretty interesting idea. @mnmtanish Check this.

from storybook.

stewartduffy avatar stewartduffy commented on April 25, 2024 1

If there is talk of adding support for displaying code example - I think it's worth looking at how material ui do it in their docs. Quite a nice implemtation. They store their code example in external js module & import it in twice to their page. One using the raw webpack loader, they pass the result of this file into a markdown component & the pass the regular loaded example to their page component that renders the example. This way their code example stays in sync with actual component rendered. See https://github.com/callemall/material-ui/blob/master/docs/src/app/components/MarkdownElement.js & https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/FlatButton/Page.js

from storybook.

arunoda avatar arunoda commented on April 25, 2024 1

@mnmtanish and @roonyh is working on project related to this.
See: https://github.com/kadirahq/react-storybook-story

We'll launch this soon. Anyway, you can use this right now as well.

from storybook.

arunoda avatar arunoda commented on April 25, 2024

@jeef3 It's too early to say where Storybook goes. Currently, it's only work as dev tool. But we are working on a static builder. See: #88

With that, we could publish our storybook into a set of static HTML files and publish to GitHub pages (or similar).

There is also an attempt to use markdown inside stories and render proptypes. See: #19 (comment)

So, React Storybook could be used as a living style guide too.

from storybook.

necolas avatar necolas commented on April 25, 2024

With that, we could publish our storybook into a set of static HTML files and publish to GitHub pages (or similar).

I'm using this and it's a great feature. View source / edit source is complex and I'm not sure what value it adds to react development workflows.

from storybook.

antoinegrant avatar antoinegrant commented on April 25, 2024

@willdady that's what I had in mind when stating this ticket.

from storybook.

achtan avatar achtan commented on April 25, 2024

@willdady exactly!

from storybook.

ritz078 avatar ritz078 commented on April 25, 2024

Or maybe a panel showing the state and props just like React Devtools

from storybook.

danielkcz avatar danielkcz commented on April 25, 2024

Yes, that's definitely something that is missing to see what actual properties were used to display component in such state. As of now it only relies to having good enough description of the story.

from storybook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.