Comments (4)
@JReinhold @cdedreuille is this an intentional 8.0 change?
from storybook.
This was already an intentional change for Storybook 7. See #20898 and #20897
A left
property doesn't exist. You must use icon
if you want to place an icon on the left. See the property definition here: https://github.com/storybookjs/storybook/blob/next/code/ui/components/src/components/tooltip/ListItem.tsx#L175
@stevensacks Where did you find the information that the left
property can be configured? Have we documented it somewhere wrongly?
from storybook.
Ok. I see in the code you linked that even though there is a component called <Left>
the “left” prop has been removed in favor of an “icon” prop. I noticed there are two props for the center called “center” and “title”, and a “right” prop for the <Right>
component. The naming isn’t consistent, so it’s a bit confusing 😅
The “icon” prop is not technically an icon, it’s a ReactNode, so it could be text, or an emoji (like my example usage). Maybe that’s why it was named “left” all these years? 🤷🏻♂️
I’ll change my addon to use the new name, but since this is a breaking change for all addons that use the TooltipListLink component, it should be included in the migration docs 🙏🏼
from storybook.
@stevensacks I have added an entry to the migration docs here:
#26324
Please reach out if you need some further help. And don't get confused about the icon
property in globalTypes
, because before we pass the icon further to the ToolTipListLink
component, we will pass the string into the Icon
component from @storybook/components
(which is deprecated).
And I agree. The API of the TooltipListLink is pretty messy. I hope, at some point, we can clean it up! Thanks for pointing it out.
from storybook.
Related Issues (20)
- [Bug]: Cannot read properties of undefined (reading 'every') when using essentials addon with typescript HOT 2
- [Documentation]: IS_STORYBOOK env variable is not defined anymore HOT 1
- [Bug]: accidentally ending a title with a `/` breaks storybook HOT 2
- [Bug]: Ember with Storybook 8 doesn't work
- [Bug]: ExceedsStorageRange errors + sloooow experience with Storybook 8 + NextJS HOT 3
- [Tracking]: Save from Controls
- [Bug]: Javascript heap out of memory when doing build-storybook when using docgen: 'vue-component-meta' HOT 1
- [Bug]: react-docgen fails on match(regex) inside promise. HOT 3
- [Bug]: Source maps fail to load with "Unsupported URL scheme" HOT 2
- [Bug]: Error in component stories using Drawer component in MUI HOT 8
- [Project SfC]: Create a server channel API to edit the args of a story or to create a new story
- [Project SfC]: Create a server channel API to create new story files triggered by the manager UI
- [Project SfC]: Provide a server channel API to get a list of files on the filesystem
- [Project SfC]: Create a toolbar to save arguments for existing or new stories
- While hitting tab key from the "skip to sidebar" button the keyboard focus is landing on the entire default page.
- [Bug]: Next JS addon shows errors using compiled .js instead of original .ts HOT 2
- Automigration for adding VTA on upgrade HOT 3
- Screen reader is not announcing the selection state of the "Violations"/"Passes"/"Incomplete" tab items in Accessibility Tab.
- Unable to use `Canvas` in doc-only MDX after upgrading to Storybook 8 HOT 3
- [Bug]: AutoDocs code view tags escaped and unusable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storybook.