Coder Social home page Coder Social logo

Comments (15)

arunoda avatar arunoda commented on April 25, 2024

Yeah. That'd a great feature.
For now you can resize your browser :)

from storybook.

arunoda avatar arunoda commented on April 25, 2024

BTW: Is there any open source we can use.

from storybook.

kokjinsam avatar kokjinsam commented on April 25, 2024

you mean a viewport resizer like this? demo.

from storybook.

arunoda avatar arunoda commented on April 25, 2024

Yeah. That one looks nice.

from storybook.

kokjinsam avatar kokjinsam commented on April 25, 2024

@arunoda , I'm currently working on viewport resizer and other stuffs for my team. I have a partially working viewport resizer. I might put in a PR this weekend or next week.
react-storybook

Added:

  1. simple viewport resizer
  2. toggle controls and action logger

Some features that I will be adding:

  1. manual resizer
  2. 'hay' resize
  3. random resize
  4. a set of preset viewport sizes

from storybook.

arunoda avatar arunoda commented on April 25, 2024

Awesome. Looking forward to that.
I could may help it to go with the styling as well.

from storybook.

D1plo1d avatar D1plo1d commented on April 25, 2024

I'd definitely want the ability to see multiple sizes at once. Here's what it looks like in my (now way too similarly named) ReactStoryboard project:

PS. I'd be stoked to merge these two projects if there's an interest.

from storybook.

kokjinsam avatar kokjinsam commented on April 25, 2024

@D1plo1d , that looks awesome! You already have all the features that I want to implement. If you're gonna do a PR then I will stop working on mine and work on yours later.

from storybook.

arunoda avatar arunoda commented on April 25, 2024

@D1plo1d this looks great.
I think as the start we can go with a simpler solution just like with Google Resizer.

First we have ways to see it in different resolutions. For multiple windows, we may need to work bit on data communication layer. Since the compoenet actually render on the iframe.

So, let's first go with the @sammkj 's way.
Then once we have it, we can step into the multi window view.

Can't wait to integrate these cool features.

from storybook.

D1plo1d avatar D1plo1d commented on April 25, 2024

@sammkj thanks!

I'm not sure if you should stop working on your component right away. I think @arunoda's got a point: The more I'm reading react-storybook's src the more I'm seeing implementation differences that would make cherry picking features difficult without larger changes.

I've got some ideas on how a merge could be done. @arunoda I don't want to step on any toes, could we have a quick skype call next week some time to discuss this?

PS. forgot the first time, here's a link to my project: https://github.com/D1plo1d/react-storyboard

from storybook.

arunoda avatar arunoda commented on April 25, 2024

@D1plo1d yes sure. I am happy to.
Drop me an email to [email protected] and let's schedule a time.

from storybook.

kokjinsam avatar kokjinsam commented on April 25, 2024

@arunoda, regarding multiple windows, can we just duplicate the iframe in the layout component? I don't understand the data communication part.

from storybook.

arunoda avatar arunoda commented on April 25, 2024

@sammkj we can. We get data into the admin panel via the iframe and admin panel actions like selected story back to the iframe.

With multiple iframes things may go wrong. I didn't tested that.
But fixing that would be straight forward too.

I will work on that.

from storybook.

borisyankov avatar borisyankov commented on April 25, 2024

You can point Google Resizer to localhost:9001

from storybook.

arunoda avatar arunoda commented on April 25, 2024

Check this comment: #17 (comment)

I'm going to close this in favour of the PR comments thread.
And we won't have a built-in resizer, but users could use browser tools and existing stuff with the FullScreen API.

from storybook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.