Comments (3)
@KurenevAlexandr, thanks a lot for reviewing our project!
We'll definitely pay attention to the found issues in the near future.
Adding static code analysis to our CI pipeline is also on our to-do list.
Thanks again for the report!
from storm-engine.
I checked your project with the PVS-Studio static analyzer.
Some analyzer warnings seemed interesting to me, so I wrote an article about them: https://habr.com/ru/company/pvs-studio/blog/564698/. I think it will be useful to you.
Part of the warnings pointed to lines of code marked with special comments. Seems like you are aware of problems in your code.
Note. As open project developers, you can use one of free licensing options. If you find the analyzer interesting, you can use it regularly. Ways to Get a Free PVS-Studio License: https://pvs-studio.com/en/blog/posts/0614/
Thanks for noticing us 🙂
Actually, I made plenty of critical SCA fixes back in the days, so the most issues from the original (the state in that we got the engine) engine had gone.
Indeed, I marked down many non-critical issues and almost ignored minor ones.
Also, most issues from the article come from recent commits.
That is probably a good reason to think about integrating SCA into the pipeline :)
I'm sure we will come back to it and consider using PVS-Studio after solving more important problems that affect the whole project
from storm-engine.
I've looked through it again. Most of the alarms don't affect the code or need more complex solution. But there are some useful ones as well, I'll take care of them so I'm closing this for now. Thanks once again.
P.S. it's a bit weird that PVS-Studio treats srv.malloc as std::malloc. I'm wondering if it was done intentionally, but that's a bit confusing considering the fact it uses new
internally
from storm-engine.
Related Issues (20)
- ShipMan::SetAnimation HOT 1
- Improve #258 to pass PR branch/hash
- RaiseException
- Ship icon instead of Sea on world map HOT 3
- Tracking issue: Linux port using dxvk / gallium nine HOT 5
- Feature: understand why bPostProcessEnabled is false and what will happen after enabling it HOT 1
- Need to case-convert non-ascii text HOT 1
- Issue with head rendering in LegacyDialog HOT 2
- Convert Float to String HOT 2
- [BUG] Can't load texture resource\textures\.tx
- [BUG] SoundService::GetRandomName HOT 1
- Needs to be reverted HOT 1
- [BUG] Linux build: _DEBUG macro is not set
- Use DXVK instead of DXVK Native HOT 2
- If there is no last name, then do not add a space in the dialog box. Ready code HOT 2
- Strange code when creating ships HOT 6
- [BUG] CMake Error HOT 6
- [BUG] EqMultiply(const CMatrix &m1, const CMatrix &m2) can be called with invalid m1 matrix HOT 5
- [BUG] dutch gambit terks navy battle message vector out of range
- [BUG]Cmake Conan 1.63 ERROR HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storm-engine.