Fully support any GlobalId-able entity about futurism

[julianrubisch]

Should be doable if we scan for inclusion of that module. Also, would require adapting the tests.

[rickychilcott]

I was thinking:

      def transformed_options
        require_relative "shims/deep_transform_values" unless options.respond_to? :deep_transform_values

        options.deep_transform_values do |value|
          if value.is_a?(ActiveRecord::Base) && !value.new_record?
            value.to_global_id.to_s
          else
            value
          end
        end
      end

becomes:

      def transformed_options
        require_relative "shims/deep_transform_values" unless options.respond_to? :deep_transform_values

        options.deep_transform_values do |value|
          if value.respond_to?(:to_global_id) && !value.try(:new_record?)
            value.to_global_id.to_s
          else
            value
          end
        end
      end

I can write some tests for this too

[julianrubisch]

Yep, could go with duck typing, here are some other options:

https://stackoverflow.com/a/28667632

[rickychilcott]

I'm going to do a PR tomorrow.

I'm currently preferring duck typing instead of ancestors, looking for specific classes/included modules, etc. Maybe it's just personal preference, but a) we do duck typing just a few lines above, and if we would have not pegged it to a specific class, this just would have been supported out of the box. The specific module could change, there could be other abstractions that implement a similar interface, etc.

[julianrubisch]

I'm fine with it, just wanted to provide options.