Coder Social home page Coder Social logo

Comments (5)

kohenkatz avatar kohenkatz commented on May 10, 2024

Thinking about it, probably the easiest way to do this is to add a check here for "if this is a function that takes no arguments"

from knockout-es5.

mbest avatar mbest commented on May 10, 2024

Isn't that already done here?

from knockout-es5.

mbest avatar mbest commented on May 10, 2024

Sorry. It looks like when using ko.track that functions aren't converted to ko.computed, but to a regular ko.observable.

from knockout-es5.

kohenkatz avatar kohenkatz commented on May 10, 2024

I made the change and added a test for it in https://github.com/kohenkatz/knockout-es5/tree/patch-1

Should I make a Pull Request for it?

from knockout-es5.

mbest avatar mbest commented on May 10, 2024

According to http://blog.stevensanderson.com/2013/05/20/knockout-es5-a-plugin-to-simplify-your-syntax/, functions are supposed to be left alone, but since they aren't, this change seems like a good one. I'm not a maintainer here, but just commenting.

from knockout-es5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.