Comments (5)
Thinking about it, probably the easiest way to do this is to add a check here for "if this is a function that takes no arguments"
from knockout-es5.
Isn't that already done here?
from knockout-es5.
Sorry. It looks like when using ko.track
that functions aren't converted to ko.computed
, but to a regular ko.observable
.
from knockout-es5.
I made the change and added a test for it in https://github.com/kohenkatz/knockout-es5/tree/patch-1
Should I make a Pull Request for it?
from knockout-es5.
According to http://blog.stevensanderson.com/2013/05/20/knockout-es5-a-plugin-to-simplify-your-syntax/, functions are supposed to be left alone, but since they aren't, this change seems like a good one. I'm not a maintainer here, but just commenting.
from knockout-es5.
Related Issues (20)
- Functions as computed HOT 2
- Add array support for deep track HOT 4
- Item which is already an observable array does not get wrapped with mutators
- Add latest to NPM? HOT 6
- Add to definitely typed? HOT 7
- getObservableArray support?
- update to ko 3.4.0 HOT 1
- Not working via npm? HOT 3
- Update NPM repo
- How do you get an observable within an observableArray? HOT 13
- Create release w/o weakmap polyfill
- Weakmap is not referenced as dependency, but is required by package. HOT 2
- Would you please update the version in npm? HOT 1
- Recalculation Never Happens in a Nitch Case HOT 1
- Breaks F12 Tools in IE11 HOT 2
- Uncaught TypeError: Function.prototype.toString is not generic for inspecting variables HOT 2
- Cannot write to an observable received as param inside of component
- how to access $rawData
- Computeds should be pureComputeds?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knockout-es5.