Unusable error message when anything but 200 OK is returned about thirtyfour

[stevepryde]

v0.24.0 is live :)

[stevepryde]

Ok I might put up a PR and get you to check it. Give me a few minutes

[TilBlechschmidt]

It looks like this problem originates in this method. It takes a status code and a deserialised JSON value. However, since the response body is not a JSON object, it can not be deserialised and hence null is returned.

The minimal change I'd propose is to change line 178 to also return the status code. The optimal change would be to change it so that the non-deserialised body content is passed to the function (or alternatively, just squeeze the raw body into a serde_json::Value of type String and pass that to the function in case the deserialisation fails).

[stevepryde]

So the WebDriverError::UnknownResponse variant could be modified to include status code and the body (as text?). Would that work for you?

[TilBlechschmidt]

Yeah that'd be the preferred solution! That way it would be possible to debug errors where something went horribly wrong and you don't get JSON back 😉

[stevepryde]

#51

[TilBlechschmidt]

Works as expected (see PR)

[TilBlechschmidt]

Thank you for the very quick fix! 😊

[stevepryde]

Haha all good - I just happened to check my notifications after you sent it. Easy fix (and something I've wanted as well). Thanks for pointing out where the change needed to go. That saved a lot of time.

I'll publish this version now