Tokio panic with Unordered about thirtyfour

[panicbit]

The issue is that the execute future gets polled and then dropped before finishing. This drops the receiver (ret_rx) and makes this send panic as a result.

[panicbit]

Yes, ignoring the error is likely the way to go. We tried it for the application in the OP and it seemed to work fine.
Regarding logging, I'd probably go with a Debug loglevel, since this event seems fairly uninteresting outside of this crate.

[Tockra]

@stevepryde could you notify me here, when this fix is in the crates.io version of this crate? Until then I will use a local git branch ;)

[panicbit]

Minimal repro:

use thirtyfour::prelude::*;
use tokio::time::*;

#[tokio::main]
async fn main() -> WebDriverResult<()> {
    let caps = DesiredCapabilities::chrome();
    let driver = WebDriver::new("http://localhost:9515/", &caps).await?;

    let fut = driver.get("http://example.org");
    let _ = timeout(Duration::from_millis(1), fut).await;

    Ok(())
}

[stevepryde]

Ok that makes sense. So I assume in this case it should probably just ignore the send error? Perhaps we can log it as a warning and then continue.

[stevepryde]

Good point 👍

[Tockra]

I had a little bit panic, but as panicbit says after removing the expect, my application works again.

[stevepryde]

@Tockra I've uploaded a fix in v0.23.1 which should be on crates.io now. Let me know if this fixes the issue.