[Design] .get_attribute() should return a Option if null about thirtyfour

[stevepryde]

The first option (breaking change) seems like the right approach here

[stevepryde]

I assume the same should apply to get_property() and get_css_property()

[audioXD]

I agree with get_property(), but i don't know for get_css_property()...

[audioXD]

Wouldn't a CSS property always have a value, unless the name is invalid?

[audioXD]

I've tested it and when running

c.get("https://google.si").await?;
println!("Value: {:?}", c.query(By::Css(r#"html"#)).wait().first().await?.get_css_property("background-colo").await?);
println!("Value: {:?}", c.query(By::Css(r#"html"#)).wait().first().await?.get_css_property("background-color").await?);

It returns

Value: ""
Value: "rgba(0, 0, 0, 0)"

It returns a empty string if the name is invalid

[stevepryde]

If you look at the code for get_attribute() you will see that if the value is not a string type then it converts it into a string. That should probably just return None instead (and Some if it is a string type).

[stevepryde]

The same logic is used for the other two methods which is why I suggested they would benefit from the same change

[audioXD]

The standard for get_css_property() says that to return "" in the else case, so making it a Option (by checking if not a string) wouldn't do anything .

[stevepryde]

Fair enough 👍

[stevepryde]

Fixed in 9f506dc