Comments (9)
Yeah, OK, I guess technically that is true. I'm not going to go through the effort of changing them though. If someone submits a patch that fixes this, then I would apply it.
from iverilog.
Does anybody find this issue to be important, or can I close it?
from iverilog.
I think this should be done if/when we have some spare time. Even better it is the perfect task for someone who wants to help out, but does not want to tackle learning the code base. I am guessing there are other simple rules like this that we have unknowingly violated over the years that could also be addressed.
To me the big issue is preventing these issues from creeping back in since we are all creatures of habit. For example every few months I submit a patch that fixes compilation and cppcheck warnings created by recent patches.
from iverilog.
Fixing the header file identifiers should be easy to automate, and would take care of the bulk of the transgressions. I could take a look at this once the vec4-stack merge is done. As for the rest, I agree with Cary - fix them up as/when we have spare time or are working on that bit of code.
As for other issues that creep in, can we add an automatic pre-commit check to catch some of these? I'm thinking particularly of white space errors - I always mean to check for these before committing, but don't always remember.
from iverilog.
I have pushed a patch that updates all the header file protection code to use IVL_ as the prefix instead of __.
from iverilog.
Thanks for your source code improvement.
from iverilog.
How do you think about to reconsider also the use of a prefix like "__vpi
" in your source code?
from iverilog.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/26/2015 02:10 PM, Markus Elfring wrote:
How do you think about to reconsider also the use of a prefix like
"|__vpi|" in your source code
?Line 96 in 62abb19
The
specific example of the __vpiHandle class is probably something
that could stand to be changed. If anybody comes up with a patch,
I'd be willing to check it for approval.
Steve Williams "The woods are lovely, dark and deep.
steve at icarus.com But I have promises to keep,
http://www.icarus.com and lines to code before I sleep,
http://www.picturel.com And lines to code before I sleep."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlUUfPwACgkQrPt1Sc2b3infGwCeK+8Ms5lAFzmkEcFGVWrxw8MD
INgAoOZS8A+YSypStp+XeD4TNhETh/As
=FisT
-----END PGP SIGNATURE-----
from iverilog.
How do you think about to replace such a questionable prefix by a standard-compliant name space?
from iverilog.
Related Issues (20)
- Non-interactive mode of vvp (-n, -N) seems to be broken HOT 3
- Uninformative "syntax error" message when an undefined package name is used HOT 4
- No error or warning reported when a vector lsb or msb value contains `x` or `z` bits HOT 7
- function being classified as non-constant HOT 3
- no warning for scaler being access with indexed part select. No warning for double assignment of combiniational logic HOT 2
- incomplete for statement produces no output. HOT 9
- $display not working inside function during non clocked execution HOT 2
- icarus gets caught in a infinite combi loop and I'm not sure why. HOT 4
- infinant loop in recursive function causes crash HOT 2
- Assertion Failure in AST Processing: node->bits == v at frontends/ast/ast.cc:855 HOT 1
- Simulation results discrepancy HOT 1
- Unpacked localparam array support
- Simulation mismatches in RTL vs post synthesis netlist(Yosys generated) co_simulation HOT 2
- During simulation, iverilog incorrectly assigned a value to a variable that was not driven. HOT 7
- iverilog err cannot found CXX_ABI_1.3.8 HOT 1
- Save and Restore simulation state HOT 2
- Trying to use IVerilog throws "The system cannot find the path specified" error on Windows HOT 1
- Compiler fails to initialize array value for vvp HOT 6
- During simulation, iverilog mistakenly assigned a value to an undriven variable. HOT 2
- vvp hangs forever on msys2 but does not on linux HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iverilog.