Coder Social home page Coder Social logo

Comments (7)

stevegrunwell avatar stevegrunwell commented on June 16, 2024

It seems like this conflicts with #3 (which removed the explicit path), so that will require a bit more digging to determine the best approach.

The installed_paths directory is being installed relative to the bin/ directory where PHP_CodeSniffer is installed, so ensuring the local install is used should (theoretically) fix the issue with out-of-date coding standards as a result.

from wp-enforcer.

leewillis77 avatar leewillis77 commented on June 16, 2024

Hmm, Composer doesn't magically add that to your path. I suspect the originally reporter of #3 meant that the PATH will have vendor/bin prefixed ONLY when running the post-install/update commands - it doesn't get added to your general shell's PATH (AFAIK - it certainly isn't for me)

from wp-enforcer.

leewillis77 avatar leewillis77 commented on June 16, 2024

So,

"post-install-cmd": [
    "wp-enforcer"
],
"post-update-cmd": [
    "wp-enforcer"
]

Is still valid. But anywhere else we should use explicit paths?

from wp-enforcer.

stevegrunwell avatar stevegrunwell commented on June 16, 2024

@leewillis77 Yeah, phpcs is getting called without an explicit prefix in the actual Git hook that gets copied. Other than that we should be clean.

from wp-enforcer.

leewillis77 avatar leewillis77 commented on June 16, 2024

Yes, and I can confirm that changing that to include the specific path to the local phpcs resolves the issue with it being able to find the relevant standards. Happy to raise a PR?

from wp-enforcer.

stevegrunwell avatar stevegrunwell commented on June 16, 2024

Always happy to look at a PR :)

from wp-enforcer.

stevegrunwell avatar stevegrunwell commented on June 16, 2024

Fixed by #13, will be released on 0.4.0 :)

from wp-enforcer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.