Comments (7)
It seems like this conflicts with #3 (which removed the explicit path), so that will require a bit more digging to determine the best approach.
The installed_paths
directory is being installed relative to the bin/
directory where PHP_CodeSniffer is installed, so ensuring the local install is used should (theoretically) fix the issue with out-of-date coding standards as a result.
from wp-enforcer.
Hmm, Composer doesn't magically add that to your path. I suspect the originally reporter of #3 meant that the PATH will have vendor/bin prefixed ONLY when running the post-install/update commands - it doesn't get added to your general shell's PATH (AFAIK - it certainly isn't for me)
from wp-enforcer.
So,
"post-install-cmd": [
"wp-enforcer"
],
"post-update-cmd": [
"wp-enforcer"
]
Is still valid. But anywhere else we should use explicit paths?
from wp-enforcer.
@leewillis77 Yeah, phpcs
is getting called without an explicit prefix in the actual Git hook that gets copied. Other than that we should be clean.
from wp-enforcer.
Yes, and I can confirm that changing that to include the specific path to the local phpcs resolves the issue with it being able to find the relevant standards. Happy to raise a PR?
from wp-enforcer.
Always happy to look at a PR :)
from wp-enforcer.
Fixed by #13, will be released on 0.4.0 :)
from wp-enforcer.
Related Issues (20)
- Not working! HOT 10
- Automated testing HOT 3
- Move master to a stable branch and promote develop to the in progress branch. HOT 2
- Move package changelog to CHANGELOG.md
- Rewrite for the PHP CLI? HOT 8
- Restrict hook to the changed code HOT 12
- Add support for JavaScript coding standards HOT 4
- Support custom PHPCS rulesets HOT 1
- Modifications to the phpcs.xml are picked up and won't allow a commit HOT 2
- No output from wp-enforcer setup script HOT 2
- FYI
- [docs] Install for --dev HOT 1
- Release 1.0.0 HOT 3
- [docs] Update installation instructions Re: Composer Commands HOT 1
- Require latest version of WPCS always HOT 7
- Respect config settings when creating pre-commit hook HOT 4
- Update README to signify where to add custom scripts
- Script overwrites installed coding standards HOT 2
- Checker prevents adding image files to repo HOT 1
- How about a github bot? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-enforcer.