warnings during compile on mac about acornfsutils

[SteveFosdick]

Can you try this now, please?

In looking at this I remember why I didn't include a prototype for that callback function: it is being passed fread or fwrite which may have a slightly different prototype on different systems, especially const and restrict. So I have resorted to a cast to avoid substituting one warning for another.

[acheton1984]

Thanks, with the changes I now only see one 'status' warning during a 'make all':

cc -O2 -Wall   -c -o afstitle.o afstitle.c
afstitle.c:13:17: warning: variable 'status' is uninitialized when used here [-Wuninitialized]
                status++;
                ^~~~~~
afstitle.c:6:19: note: initialize the variable 'status' to silence this warning
        int status;
                  ^
                   = 0
1 warning generated.

There's one other warning I missed in the original post, apologies:

cc -O2 -Wall -o acunzip acunzip.c -lzip
acunzip.c:51:71: warning: format specifies type 'unsigned long' but the argument has type 'zip_int64_t' (aka 'long long') [-Wformat]
                                    fprintf(fp, " %08X %08lX", value, size);
                                                       ~~~~~          ^~~~
                                                       %08llX
acunzip.c:88:9: warning: variable 'status' set but not used [-Wunused-but-set-variable]
    int status = 0;
        ^
2 warnings generated.

[SteveFosdick]

I have pushed some more changes that should solve these.

[acheton1984]

Absolutely perfect - thank you for your support and for looking at these issues.

% make all
cc -O2 -Wall   -c -o afsls.o afsls.c
cc -O2 -Wall   -c -o acorn-fs.o acorn-fs.c
cc -O2 -Wall   -c -o acorn-adfs.o acorn-adfs.c
cc -O2 -Wall   -c -o acorn-dfs.o acorn-dfs.c
cc   afsls.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afsls
cc -O2 -Wall   -c -o afstree.o afstree.c
cc   afstree.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afstree
cc -O2 -Wall   -c -o afscp.o afscp.c
cc   afscp.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afscp
cc -O2 -Wall   -c -o afschk.o afschk.c
cc   afschk.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afschk
cc -O2 -Wall   -c -o afstitle.o afstitle.c
cc   afstitle.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afstitle
cc -O2 -Wall   -c -o afsmkdir.o afsmkdir.c
cc   afsmkdir.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afsmkdir
cc -O2 -Wall   -c -o afsrm.o afsrm.c
cc   afsrm.o acorn-fs.o acorn-adfs.o acorn-dfs.o   -o afsrm
cc -O2 -Wall    ide2scsi.c   -o ide2scsi
cc -O2 -Wall    scsi2ide.c   -o scsi2ide
cc -O2 -Wall -o acunzip acunzip.c -lzip
%