username not appearing in data csv-file and table exporter crash if eid is included about ukbaid

[lwjohnst86]

I think I fixed some of the issues. See the new way of creating the dataset: https://github.com/steno-aarhus/ukbAid/blob/main/inst/templates/create-data.R

[lwjohnst86]

Ooo, that same issue again eh. Ok, thanks. If you want to try to update the data-raw script to remove that variable, that would be great!

[lwjohnst86]

I'll maybe have time to check into the create_csv_from_database() issue tomorrow

[nielsbock]

Could the missing username in the file name be due to conflicts with file_prefix being defined as "data" in builder_table_exporter ?

[lwjohnst86]

Hmm, I don't think so, since the file_prefix is actually not even used anymore within the function (it probably should be removed).

[lwjohnst86]

It might actually be something related to the rap_get_user() function though. Hmmm, looking at the code, that might be the problem actually...

[nielsbock]

hmm, rap_get_user() does output username though. I can also see in the table exporter log that the file name with username is preserved up until completion. Maybe the username in the file name is getting mixed up with the username in the path: ~/username/username-data-project_id... would it be worth testing if changing
data_file_name <- glue::glue("{username}-data-{project_id}-{timestamp_now()}")
to
data_file_name <- glue::glue("data-{username}-{project_id}-{timestamp_now()}")
will fix it?

[nielsbock]

Ooo, that same issue again eh. Ok, thanks. If you want to try to update the data-raw script to remove that variable, that would be great!

Unfortunately, I cannot detect the source of the issue. However, I can see that @arborzhang managed to create a test dataset with eid on May 30 12:47 pm. So my guess is that commits made to R/create-date.R or R/rap.R after May 30 may somehow have caused the issue.

[arborzhang]

As I reported earlier, some variables were missing when I loaded the data (data <- arrow::read_parquet("data/data.parquet"). So I tried to create a test dataset. But I only keep the test data in the folder under my name, will it influence others' work? @lwjohnst86 . PS. I am also not allowed to delete the test dataset afterwards.

[lwjohnst86]

@arborzhang it shouldn't affect others!