QuorumSet Protocol Failure about stellar-core

[spolu]

Successful run: https://gist.github.com/spolu/a44a876917a20f2f82ae
Failed run: https://gist.github.com/spolu/d6bdbfea6b96d088d351

The execution path (supposed to be deterministic) diverge here:
https://gist.github.com/spolu/a44a876917a20f2f82ae#file-success-log-L298
https://gist.github.com/spolu/d6bdbfea6b96d088d351#file-failed-log-L298

[jedmccaleb]

Well depending on how you look at it this isn't a bug. The issue is that the simulation network isn't well connected. So one node asks the 2 people it is connected to for the 4th guy's qset but they don't have it yet and he never asks again. When you connect them all it works fine.
I think we need to add something that after some time it retries to fetch qsets that it really needs.

[spolu]

As a side note on this: currently we keep calling ItemFetcher::fetchItem(qSetHash, true) whenever we need a missing qSet.