Coder Social home page Coder Social logo

Comments (5)

StatMixedML avatar StatMixedML commented on July 23, 2024

@EchoDel Thanks for raising this issue.

I would rather suggest to add an additional function that allows to return the trained lgb.Booster so that you can use it for further analysis. What do you think?

from lightgbmlss.

EchoDel avatar EchoDel commented on July 23, 2024

I'm looking for the parameters after the transformations and the probabilities so to avoid duplicating the code in the distribution class I would prefer either specifying the kwargs or being able to pass the raw predictions in to the distribution class to apply the transformations.

from lightgbmlss.

StatMixedML avatar StatMixedML commented on July 23, 2024

Yeah, you are probably correct. Would be good to have the kwargs available. Not sure though when I find the time to look into it.

from lightgbmlss.

EchoDel avatar EchoDel commented on July 23, 2024

So I can work through it and submit and PR which you can merge after the tests have been added but thinking about if there is a better way to do this.
Does it make sense to change the DistributionClass.predict_dist to take a predictions argument instead of the booster and test set, then moving the booster.predict into the LightGBMLSS.predict?
Again I can work through this and submit a PR if you are happy with this change.

from lightgbmlss.

StatMixedML avatar StatMixedML commented on July 23, 2024

Sorry was busy with the recent releases. Yes makes sense, thank you. Happy if you create a first draft via a PR

from lightgbmlss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.