Coder Social home page Coder Social logo

Comments (13)

corysimmons avatar corysimmons commented on June 6, 2024

50 billion was exaggerating. The simple act of @import 'axis/animation pulls in 245,000 characters...

Definitely like the idea of animation but I'm going to have to rework this.

from axis.

jescalan avatar jescalan commented on June 6, 2024

Yep, again gzip takes it down to a very small size because a lot of them are repeated. But if you want to separate out animations that would be fine. The only issue in here is that the @keyframes does expand to all browser prefixes, but does not expose any variable that indicates "current prefix" so all declarations have all properties prefixed for all browsers. We opened an issue in stylus for this a while ago but it hasn't been closed out yet to my knowledge

from axis.

corysimmons avatar corysimmons commented on June 6, 2024

Think I ran into this with media queries and was able to fix it with unquote.

I really need to get hip to this gzip thing and see how profitable it'd be to grab h5bp's .htaccess for Jeet

from axis.

corysimmons avatar corysimmons commented on June 6, 2024

Yeah I don't see a downside in it. I'll probably port the animation stuff to it's own repo just to try to keep doing the modular thing with everything.

from axis.

jescalan avatar jescalan commented on June 6, 2024

Yeah I'm cool with moving animation to its own project if you want. I never use those anyway, usually write custom ones.

from axis.

corysimmons avatar corysimmons commented on June 6, 2024

Might actually jump on an Effeckt.css port to Stylus instead.

from axis.

jescalan avatar jescalan commented on June 6, 2024

I like that idea a lot. If you could port it, would be happy to include it with axis instead of what we have now

from axis.

corysimmons avatar corysimmons commented on June 6, 2024

Effeckt is so damn ugly. Seriously, the more I look at it the more I'm baffled people like Paul Irish and Chris Coyier worked so hard on it.

Might just make my own animation mixin library.

from axis.

jescalan avatar jescalan commented on June 6, 2024

Hahah ugly design on the alpha demo page doesn't mean that the actual animations are bad. Just re-skin the demo page if you want it to look nicer.

from axis.

corysimmons avatar corysimmons commented on June 6, 2024

haha, no not the demo page XD

I meant the code and the insane amount of classes and data- attributes it's using.

Seems like with preprocessors we could turn a lot of that crap into more flexible mixins.

from axis.

jescalan avatar jescalan commented on June 6, 2024

Ah yeah you're right, why are they not mixins? Seems weird that they wouldn't default to this. Maybe fork it and convert them into mixins?

from axis.

corysimmons avatar corysimmons commented on June 6, 2024

So far as I can tell, the only difference in the official SCSS port is that they're nesting classes... https://github.com/h5bp/Effeckt.css/tree/gh-pages/scss

from axis.

jescalan avatar jescalan commented on June 6, 2024

Yeah this is no good. The concept is great, but banking on classes is not. That's what we have preprocessors for...

from axis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.