Coder Social home page Coder Social logo

Comments (12)

staskobzar avatar staskobzar commented on May 25, 2024 3

Would you mind replacing the wontfix label with help wanted?
(I think that) the wontfix label sends a signal that you have no intention of fixing this and it works as expected, whereas help wanted shows you're willing to have this fixed, but don't have the resources for it yourself atm.

good point. changed. thanks

from vue-audio-visual.

andreasvirkus avatar andreasvirkus commented on May 25, 2024 1

Would you mind replacing the wontfix label with help wanted?
(I think that) the wontfix label sends a signal that you have no intention of fixing this and it works as expected, whereas help wanted shows you're willing to have this fixed, but don't have the resources for it yourself atm.

from vue-audio-visual.

staskobzar avatar staskobzar commented on May 25, 2024

Hello,
It also may depend on the <audio\> element. What attributes of the audio element do you use?
Also, does it works without v-show condition?

from vue-audio-visual.

szokeptr avatar szokeptr commented on May 25, 2024

My audio tag looks like this:

<audio 
    ref="player" 
    :src="audioSource" 
    :title="radio.now_playing.song.title" 
    crossorigin="anonymous"
></audio>

audioSource is a streaming mp3 file, title is a plain string with the song title.

Also, it's not working without the v-show condition either (I removed the directive entirely).

from vue-audio-visual.

szokeptr avatar szokeptr commented on May 25, 2024

Quick note: I tried pulling the canvas contents with the toDataURL method and it appears to be a static un-styled blue circle all the time.

from vue-audio-visual.

staskobzar avatar staskobzar commented on May 25, 2024

I can not find the way to fix it for safari. Spent whole day playing with different parameters and re-writing code trying to fix it.
I am sorry but I have to leave it like this until I find any other way to fix it or may be Apple will do something with Safari. May be someone will contribute a fix.

from vue-audio-visual.

andreipopovici avatar andreipopovici commented on May 25, 2024

For macOS Safari at least, the AudioContext needs to be created on "user interaction" i.e. inside the context of a click event. This would require some significant refactoring. Both the audio element that gets created and the one attached via refLink need an onclick listener, and setAnalyser needs to be called inside that listener, not in mount().

I'll play around and see if I can fix this and open a PR.

from vue-audio-visual.

staskobzar avatar staskobzar commented on May 25, 2024

@andreipopovici thank you. Your patch works great with my tests (macOS/Safari 13.1). Just merged. Will be released in ver 2.0.1

from vue-audio-visual.

andreipopovici avatar andreipopovici commented on May 25, 2024

After spending way too many hours, I realized why the fix in #33 was not working on mobile Safari. It's a bug that has ben acknowledged but not fixed yet: https://bugs.webkit.org/show_bug.cgi?id=203435

Nothing more to do here 🤷‍♂️

from vue-audio-visual.

staskobzar avatar staskobzar commented on May 25, 2024

Good, thank you @andreasvirkus
This one took me many hours too but I could not find it. I do appreciate your contribution.

I'm closing this ticket. Have a good week-end!

from vue-audio-visual.

andreipopovici avatar andreipopovici commented on May 25, 2024

It looks like that bug was fixed via https://bugs.webkit.org/show_bug.cgi?id=211394 in iOS 13.6 upward, but I didn't have a chance to test and see if it's fixed this particular issue. Hopefully it did!

from vue-audio-visual.

staskobzar avatar staskobzar commented on May 25, 2024

Good! hopefully it does.
Thank you

from vue-audio-visual.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.