Coder Social home page Coder Social logo

Comments (8)

miyconst avatar miyconst commented on June 11, 2024

Here is the new branch:
https://github.com/Starcounter-Jack/JSON-Patch/tree/issues/73

The exception name is OPERATION_VALUE_CANNOT_CONTAIN_UNDEFINED, I added OPERATION_ to match all other exceptions and removed _OBJECT to shorten it somehow.

Three new validation specs added:

should return an error if an "add" operation "value" contains "undefined"
should return an error if a "replace" operation "value" contains "undefined"
should return an error if a "test" operation "value" contains "undefined"

with the following operation values:

{ foo: undefined }
{ foos: [undefined] }
{ foo: { bars: [undefined] }} }

from json-patch.

warpech avatar warpech commented on June 11, 2024

@tomalec can you review?

from json-patch.

tomalec avatar tomalec commented on June 11, 2024

Check itself LGTM, but we need that change to be made in .ts files as well.

from json-patch.

miyconst avatar miyconst commented on June 11, 2024

Updated .ts files. How do you test TypeScript? There is nothing about it in the project.

from json-patch.

tomalec avatar tomalec commented on June 11, 2024

U should use tsc in command-line to generate js out of ts, then test js ;)

from json-patch.

miyconst avatar miyconst commented on June 11, 2024

@tomalec thanks, tested.

from json-patch.

tomalec avatar tomalec commented on June 11, 2024

cool, can you merge it to the master, and close the issue?

from json-patch.

miyconst avatar miyconst commented on June 11, 2024

Done. Released 0.5.3 version.

from json-patch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.