Panic When Accessing Resource via Context about kayak_ui

[MrGVSV]

Does it panic if you move that same resource access into a custom widget?

My guess is that we actually don't have access to World at this point.

[Psikik]

Seems to be that way. I hadn't yet ventured into custom widgets yet. Building a custom widget that checks world.is_err() as in the full_ui example does not panic.

[MrGVSV]

Hm, yeah it probably is:

kayak_ui/bevy_kayak_ui/src/bevy_context.rs

Lines 40 to 49 in f90c054

	pub fn new<F: Fn(&mut KayakContext)>(f: F) -> Self {
	let kayak_context = Arc::new(RwLock::new(KayakContext::new()));
	if let Ok(mut kayak_context) = kayak_context.write() {
	f(&mut kayak_context);
	kayak_context.widget_manager.dirty(true);
	}
	Self { kayak_context }
	}

I think the only way to achieve this unfortunately would be to do so within a widget— where World access is guaranteed— rather than within the constructor function for BevyContext.

This means that we should probably make query_world a pub(crate) access instead of a pub one so other users don't stumble upon the same issue. This should be okay since the only pub access (that I know of) is here:

kayak_ui/bevy_kayak_ui/src/lib.rs

Lines 73 to 78 in f90c054

	context.query_world::<(
	EventReader<CursorMoved>,
	EventReader<MouseButtonInput>,
	EventReader<ReceivedCharacter>,
	EventReader<KeyboardInput>,
	), _, _>(

So that will probably need to be dealt with as well (perhaps by just simply moving the process_event system into the update system).

[StarArawn]

BevyContext::new( wont have access to world here. Another suggestion would be to load in the resource via the create_ui system.

[MrGVSV]

Another suggestion would be to load in the resource via the create_ui system.

Actually, yeah this might be a simpler solution assuming you can pass the resource into the closure (which is probably trivial for your RandomResource type since it could implement Copy).

[StarArawn]

Since solutions to the problem above have been suggested I'm going to close this for now. Feel free to open up a new issue if you feel there is more to do here.