Impl Add for Style? about kayak_ui

[StarArawn]

I think having both has merits 👍 I think the operator internally would just use with_style? I've also been thinking of having a way of defining "classes" or at least some sort of reusable style similar to JSS.

[CaioLC]

with_style works exactly as needed. Still new to kayak_ui so thanks for pointing out the functions 😃

There might be some cosmetic value in having the "+" operator to concatenate different styles, though. For instance, this code:

<Background styles={Some(container_style
    .with_style(center_align)
    .with_style(main_background_color)
    .with_style(two_players)
)}>
</Backgroud>

would become:

<Background styles={Some(container_style + center_align + main_background_color + two_players)}>
</Backgroud>

Some food for thought, in case you want to copy/paste the with_style method as the implementation for the Add<Style> operator.

[MrGVSV]

Interesting... Would you be willing to draft up a PR so we can take a look at it in real examples? It might be a nice QoL feature. Any thoughts on this @StarArawn?

One hesitation here is that it hides the ordering considerations (A + B ≠ B + A) a bit more than with_style already does.

[StarArawn]

Add PR has been merged so I will be closing this. 👍

[MrGVSV]

Check out the methods defined on Style here:

kayak_ui/kayak_core/src/styles/mod.rs

Lines 150 to 188 in 54c67ec

	/// Returns a `Style` object where all fields are set to [`StyleProp::Default`]
	///
	/// This should only be used when default properties are required or desired. Otherwise, you
	/// may be better off using `Style::default` (which sets all properties to [`StyleProp::Unset`]).
	pub fn new_default() -> Self {
	Self {
	$($field: StyleProp::Default),*
	}
	}
	/// If any field is set to [`StyleProp::Inherit`], its value will be taken from `other`
	pub fn inherit(&mut self, other: &Self) {
	$(
	if matches!(self.$field, StyleProp::Inherit) {
	self.$field = other.$field.clone();
	}
	)*
	}
	/// Applies a `Style` over this one
	///
	/// Values from `other` are applied to any field in this one that is marked as [`StyleProp::Unset`]
	pub fn apply<T: AsRefOption<Style>>(&mut self, other: T) {
	if let Some(other) = other.as_ref_option() {
	$(
	if matches!(self.$field, StyleProp::Unset) {
	self.$field = other.$field.clone();
	}
	)*
	}
	}
	/// Applies the given style and returns the updated style
	///
	/// This is simply a builder-like wrapper around the [`Style::apply`] method.
	pub fn with_style<T: AsRefOption<Style>>(mut self, other: T) -> Self {
	self.apply(other);
	self
	}

It sounds like you want to use apply (or with_style for builder-like syntax). If a style has any StyleProp::Unset values, these methods will attempt to apply the value from the given style. Hopefully that helps! 😄