Coder Social home page Coder Social logo

Comments (4)

AngledLuffa avatar AngledLuffa commented on May 27, 2024

Gah, this class is terrible. Zero documentation and apparently even the most basic functionality isn't tested. Thanks so much for uncovering it

from corenlp.

AngledLuffa avatar AngledLuffa commented on May 27, 2024

Testing on other trees of size two, it also crashes if you insert things in such an order that the left child of the balanced tree is being deleted or if the root of the balanced tree is deleted. You would think such a thing would be found before the other 500 lines of code got written.

What's debugging got to do with it, anyway?
What's debugging but a sweet old fashioned notion?
Who needs a unit test when a test can be broken?

from corenlp.

Sirius902 avatar Sirius902 commented on May 27, 2024

@AngledLuffa Thanks for the quick reply! I found the issue using a larger set of test data but cf11603 seems to have addressed the issue there as well.

from corenlp.

AngledLuffa avatar AngledLuffa commented on May 27, 2024

Now released in 4,.5.6

from corenlp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.